Commit Graph

4710 Commits

Author SHA1 Message Date
Michael Stapelberg 33fa3284db Merge pull request #1560 from shdown/refactoring
i3bar: refactoring
2015-03-22 21:29:03 +01:00
Michael Stapelberg 0b65ea5b62 Merge pull request #1557 from acrisci/bug/fix-validation-segfault
Bugfix: validation segfault
2015-03-22 14:32:36 +01:00
shdown f19fa0e3c9 i3bar: introduce get_tray_width() function to reduce duplication 2015-03-22 13:28:00 +03:00
shdown 62e4caa06c i3bar: refactor magic numbers to *_px constants 2015-03-22 13:28:00 +03:00
Tony Crisci 6fb7fc9bc6 Bugfix: validation segfault
When `new_window` is given in the config, config validation with `i3 -C`
would segfault.

Add a NULL check in logical_px() to check for the case when the config
is being validated without an X server to prevent this.
2015-03-22 05:46:52 -04:00
Michael Stapelberg 2190bb9386 Don’t overwrite border width when already set (placeholders).
fixes #1501
2015-03-21 23:02:35 +01:00
Michael Stapelberg 9493b61bb4 i3bar: set correct initial position when reconfiguring
fixes #1542
2015-03-21 22:50:48 +01:00
Michael Stapelberg 27ad651e35 Merge pull request #1556 from Airblader/feature-i3-save-tree-by-number
Allow referencing the workspace by number.
2015-03-21 22:37:42 +01:00
Michael Stapelberg 2772c377ec increase timeouts for travis
See https://travis-ci.org/i3/i3/jobs/55319961 (line 4064) for a job
where the window could not be mapped within 2 seconds.
2015-03-21 22:23:51 +01:00
Michael Stapelberg 73cd5dbb48 Merge pull request #1561 from Airblader/feature-append-layout-docs
Added a troubleshooting section to the restoring layout docs
2015-03-21 22:08:58 +01:00
Ingo Bürk 32f3248b57 Added a troubleshooting section to the restoring layout docs and described solution for vertically split containers 2015-03-21 20:41:40 +01:00
Michael Stapelberg 12e840b24d Merge pull request #1559 from shdown/next
various i3bar bugfixes
2015-03-21 18:44:02 +01:00
shdown b2309b8681 i3bar: fix click events for workspace buttons with long statusline
This combines detecting of current and clicked workspaces into one cycle
and then checks if the x coordinate of the clicked point is greater than
the workspace buttons width.
2015-03-21 19:41:38 +03:00
shdown b1c7c7eea4 i3bar: fix spelling is messages 2015-03-21 19:22:31 +03:00
shdown 4d3867f178 i3bar: rename a variable
Give it a more meaningful name.
2015-03-21 19:17:05 +03:00
shdown b28bb20caa i3bar: add binding indicator width to workspace buttons width
Just to prevent the indicator from being overlapped by the statusline.
2015-03-21 19:12:29 +03:00
Ingo Bürk 0e0581c6cb Allow referencing the workspace by number.
This allows "--workspace 3" for numbered workspaces, e.g., if the name is actually
"3:foo". This introduces the same functionality the IPC already offers in many places.
2015-03-21 17:10:20 +01:00
shdown ccd6ae8eaf i3bar: cut long statuslines from the left
This draws the statusline after drawing (and calculating width of) the
workspace buttons and fixes calculation of its maximum visible width.
This (hopefully) guarantees that these two will never overlap.
2015-03-21 19:08:40 +03:00
shdown 5efcfda2ed i3bar: fix clearing of the statusline pixmap
This fixes the bug when statusline pixmap wasn't entirely cleared that
caused random artifacts to appear when the statusline width is greater
than the screen width.
2015-03-21 19:00:11 +03:00
Michael Stapelberg e7753c839f Merge pull request #1555 from Airblader/feature-i3-save-tree-current-ws
Make the --workspace optional by defaulting to the focused workspace.
2015-03-21 16:38:46 +01:00
Michael Stapelberg 5b80713233 Merge pull request #1549 from shdown/y-offset-fix
Fix incorrect y-offset for text in i3bar (2)
2015-03-21 16:32:19 +01:00
Ingo Bürk 80f119f0e2 adapted usage text 2015-03-19 18:59:25 +01:00
Ingo Bürk d217cddb42 Make the --workspace optional by defaulting to the focused workspace.
If no option is given, i3-save-tree should default to the currently focused workspace.
Specifying both --workspace and --output will still yield an error.
2015-03-18 21:37:37 +01:00
Michael Stapelberg 09e4fb716c Merge pull request #1551 from acrisci/bug/rename-workspace-mismatch
bugfix: workspace rename focus mismatch
2015-03-16 22:49:38 +01:00
Michael Stapelberg d9c2ce0023 Merge pull request #1553 from Airblader/feature-remove-output-assignment
Remove the A_TO_OUTPUT option
2015-03-16 22:40:25 +01:00
Michael Stapelberg d1f99abf75 fix warnings when CONTINUOUS_INTEGRATION env var is unset 2015-03-16 22:38:39 +01:00
Michael Stapelberg c35b3160f6 relax timings of t/200-urgency-timer.t to reduce flakiness 2015-03-16 22:37:45 +01:00
Ingo Bürk 52f918309b Remove the A_TO_OUTPUT option as it is not needed anymore and will not be implemented in favor of normal assignments. 2015-03-16 20:18:03 +01:00
Tony Crisci 6b150b1ac2 bugfix: workspace rename focus mismatch
When renaming a workspace on another output that moves the workspace to
the current output, the renamed workspace would be shown even though it
does not contain the focused container.

Explicitly show the focused workspace after the move. This is necessary
because `workspace_move_to_output` will show the workspace that is
moved.
2015-03-15 23:30:00 -04:00
shdown 123de9a25f Fix incorrect y-offset for text in i3bar (2)
014aa7ff74 fixed incorrect align of small
symbols, but also introduced a problem with texts with mixed large and
normal symbols. Fix it by centering the text vertically only if its
height is smaller that the saved font height.
Fixes #1543.
2015-03-15 10:32:17 +03:00
Michael Stapelberg cd48bcf2a5 travis: verify code was formatted using clang-format 2015-03-14 22:32:23 +01:00
Michael Stapelberg 513510de69 clang-format src/commands.c 2015-03-14 22:32:23 +01:00
Michael Stapelberg 56f420c3dd Merge pull request #1539 from mh21/wsrename-1527
Rename workspaces in startup sequences
2015-03-14 04:56:19 -07:00
Michael Stapelberg 8eb5656c69 travis: cat complete-run.log on failures 2015-03-14 12:35:01 +01:00
Michael Stapelberg f0ef712ed0 tests: exit with status 1 when tests fail 2015-03-14 12:34:34 +01:00
Michael Stapelberg aa4aec41f5 tests: don’t print interactive status when running on travis
(or without a tty)
2015-03-14 12:33:54 +01:00
Michael Stapelberg 69be6e4a8e travis: run tests serialized, install latest AnyEvent::I3 2015-03-13 23:38:56 +01:00
Michael Stapelberg 26d17c6b88 travis: install as many perl pkgs as possible via apt instead of cpanm 2015-03-13 23:38:33 +01:00
Michael Stapelberg 2cf40f4867 travis: fix pinning setup (newlines and YAML are complicated) 2015-03-13 23:38:13 +01:00
Michael Stapelberg f8ac5fcfe2 travis: escape strings for YAML 2015-03-13 21:04:03 +01:00
Michael Stapelberg 8dd6591c59 travis: install more perl dependencies, pull in trusty packages 2015-03-13 20:52:53 +01:00
Michael Stapelberg 0b3601c2ef travis: also cat cpanm build logs after failure 2015-03-13 13:24:02 +01:00
Michael Stapelberg 9088fa03bc travis: cpanm: set -v so that we get error messages in the travis output 2015-03-13 11:39:59 +01:00
Michael Hofmann 44f748a663 Rename workspaces in startup sequences.
When renaming workspaces, any workspace names in pending startup
sequences also need to be renamed.
2015-03-13 10:35:20 +01:00
Michael Hofmann 5776edcc84 Test: startup workspaces updating on rename. 2015-03-13 10:35:20 +01:00
Michael Stapelberg 439cadf441 travis: directly use cpanm -n to skip tests
X11::XCB currently fails its tests
2015-03-13 10:21:02 +01:00
Michael Stapelberg b370c5ac71 travis runs on ubuntu 12.04, so use libinline-perl 2015-03-13 10:12:00 +01:00
Michael Stapelberg f549089c30 travis: mk-build-deps needs equivs 2015-03-13 10:09:21 +01:00
Michael Stapelberg 92d8b4d469 add configuration for travis-ci.com 2015-03-13 10:06:57 +01:00
Michael Stapelberg c263bb3d2a Merge pull request #1521 from Airblader/feature-use-refactored-function
Use the already existing function to get rid of some code duplication
2015-03-13 00:54:52 -07:00