2eb4ed95bc
Bugfix: fix “overlapping” --release key bindings (Thanks phlux)
...
We eagerly marked all KeyRelease bindings as eligible to match without
checking modifiers, while this should only be allowed for the key
binding which actually was pressed.
fixes #915
2013-01-24 14:44:01 +01:00
bfd150872d
Fixing continuous resize bug in floating mode
...
fixes #910
2013-01-24 12:42:13 +01:00
3365b52384
Allow servers which do not support the XKB extension.
...
If we can open the X display but the XKB extension is not available,
continue without it.
2013-01-23 20:27:27 +01:00
2478d0a2e0
ipc: use ipc_recv_message instead of duplicate code
...
This should fix the situation where i3 would read only the header and
not the payload of the message.
2013-01-23 18:59:36 +01:00
dcb8ac84f8
ipc_recv_message: store message_type, don’t compare. add distinct EOF retval
...
Also use ELOG, which requires i3-msg to provide logging functions.
2013-01-23 18:51:39 +01:00
2c249b6949
Merge branch 'master' into next
2013-01-01 16:31:27 +01:00
138e04fd4d
Bugfix: Fix for_window moving of assigned windows (Thanks bafain)
...
fixes #909
2013-01-01 16:31:08 +01:00
d8e27dd5aa
ignore MotionNotify events generated while warping the pointer
2012-12-27 17:04:13 +01:00
9edbcc4790
debug message for window focus: include window ID
2012-12-27 16:58:46 +01:00
54fd3d3480
unregister as window manager before restarting (fixes a race condition)
2012-12-27 16:54:54 +01:00
cde82eafa6
use xcb_aux_sync to make sure our changes reach the X server, flushing is not enough
2012-12-27 16:54:36 +01:00
0045cfa637
move visible scratchpad window to focused workspace
...
If there is a visible scratchpad on another (non-internal) workspace,
bring it to the focused workspace instead of doing nothing.
closes #784
2012-12-24 19:20:47 +01:00
b3d7531947
refactor both i3-nagbar starts into src/util.c
...
With this change, libev >= 4 is a hard dependency. It should be present
in all major linux distributions (even the latest ubuntu LTS).
2012-12-24 16:53:20 +01:00
c127ac3855
remove all references to the old cfgparse
2012-12-24 15:57:02 +01:00
b304e6ad34
remove old cfgparse.{l,y}
2012-12-24 15:46:57 +01:00
5d4a934864
render_con: initialize int sizes[children]
...
This fixes a clang-analyzer warning
2012-12-24 15:28:17 +01:00
4f2922de62
Revert "initialize array to fix clang-analyze warning"
...
This reverts commit 56e0ceb44e
2012-12-24 15:28:08 +01:00
56e0ceb44e
initialize array to fix clang-analyze warning
2012-12-24 15:19:20 +01:00
9ae73b7a2a
fix possibly uninitialized variable (Thanks knopwob)
2012-12-24 15:13:47 +01:00
1a6bddad55
Merge branch 'master' into next
2012-12-24 14:50:15 +01:00
625401d162
Bugfix: handle MapRequests sent between i3 registering as a wm and handling events
...
This fixes the problem where i3-nagbar does not come up because its
MapRequest is ignored.
fixes #892
2012-12-24 14:49:19 +01:00
24aa857a89
Bugfix: Correctly close floating windows (Thanks eeemsi)
2012-12-23 18:51:17 +01:00
3a78d489e6
Render tree before destroying X11 containers upon unmap (Thanks Merovius)
...
When an X11 window is closed (say, urxvt), i3 gets an UnmapNotify event
and destroys (DestroyWindow) the window decorations. Before this commit,
the DestroyWindow call was sent immediately.
This lead to a situation where — due to the DestroyNotify — EnterNotify
events were generated that would cause the focus to be set to the
underlying window.
With this commit, i3 first renders the tree and pushes changes to X11
before calling DestroyWindow. Therefore, the surrounding containers will
take up any space that was freed by the window which was closed and no
EnterNotify will be generated.
fixes #660
2012-12-23 15:54:49 +01:00
79bd2aede5
Draw 1px tab separators left/right instead of 2px on the right only
...
fixes #894
2012-12-22 16:15:11 +01:00
a1ccca22e6
Merge branch 'master' into next
2012-12-22 14:08:14 +01:00
36b106a9d3
Bugfix: Ignore ConfigureRequests for scratchpad windows (Thanks MeanEYE)
...
fixes #898
2012-12-22 14:08:11 +01:00
bb3ae9f960
Merge branch 'master' into next
2012-12-19 21:40:53 +01:00
721fa7bdad
Fix scrolling on a tabbed titlebar which contains split cons (Thanks f8l)
...
fixes #708
2012-12-19 21:40:26 +01:00
895f8e05c8
Merge branch 'master' into next
2012-12-19 21:13:12 +01:00
ae605bdd39
Also draw right tab border for split containers (Thanks alex)
...
fixes #696
2012-12-19 21:12:38 +01:00
73ec3dd3b0
Merge branch 'master' into next
2012-12-14 21:50:15 +01:00
7658109309
Bugfix: remove superfluous #include <xcb/xcb_atom.h> (Thanks pnutzh4x0r)
...
This fixes the build on CentOS 6.
fixes #889
2012-12-14 21:49:31 +01:00
61a5b9ddd4
Revert "don't use con_is_internal"
...
This reverts commit c6948c59f5
2012-12-14 21:44:20 +01:00
2bf7793d4d
Merge branch 'next'
2012-12-12 00:18:23 +01:00
18e46ffae5
install i3-dmenu-desktop
2012-12-11 22:31:44 +01:00
1ae08b196a
Bugfix: Don’t move floating windows when their size constraints forbid resizing (Thanks aksr)
...
fixes #883
2012-11-27 09:26:31 +01:00
19cbd3cbec
code style fixes for the previous commit
...
• our function names use underscores
• rewrote the function’s comment
• function comments must be in the source _and_ in the header
• no blank lines after function signatures
2012-11-25 20:55:49 +01:00
f41fa1baa1
The command to resize a floating window now checks the minimum and maximum size.
2012-11-25 20:52:56 +01:00
d2b533328d
Fix memory leaks in config_parser.
...
push_token() doesn't take ownership of its str argument.
2012-11-24 17:39:52 +01:00
3cb909fa62
config parser: recover after invalid input
...
This is done by ignoring the rest of the current line and jumping to the
nearest <error> token.
fixes #879
2012-11-20 17:10:29 +01:00
305b6ddf2f
set LC_NUMERIC=C when dumping nodes in the workspace event
...
Otherwise the resulting JSON might be invalid because it uses the
locale-specific comma separator, e.g. "16,666" instead of "16.666".
2012-11-13 09:49:08 +01:00
1055973f66
refactor, name changes
...
We need to send the workspace event earlier, because otherwise 'old'
might already be destroyed (if it was empty).
2012-11-13 09:40:06 +01:00
464d387044
take care of non-existant old workspaces
2012-11-13 09:33:03 +01:00
74d596e0fc
more informative `workspace' events
...
Add a `current' and `old' properties to the `focus' change type,
containing the current and old workspace respectively. These additions
are not necessary anywhere else because `focus' is always triggered when
changing ws.
2012-11-13 09:33:00 +01:00
b67eedf71a
simplify yajl related code
...
Specifically, put the version dependent code in some macros, and put
that plus the `y' and `ystr' macros in a separate file, `yajl_utils.h'.
2012-11-13 09:32:55 +01:00
c6948c59f5
bugfix: don't use con_is_internal
...
fixes #872
2012-11-12 19:49:01 +01:00
dece12bf18
Merge branch 'master' into next
2012-11-10 09:01:24 +01:00
81393c93c2
bugfix: fix workspace back_and_forth after displaying a scratchpad window
...
fixes #868
2012-11-10 09:01:04 +01:00
ae14fe9141
introduce new command to rename focused workspace
...
The corresponding command is 'rename workspace to <name>'. As a side-effect
this fixes the command 'rename workspace 1 to to'.
Signed-off-by: Michael Walle <michael@walle.cc>
2012-10-31 09:09:56 +01:00
71ccb4bef2
Merge branch 'master' into next
2012-10-29 16:42:11 +01:00
e7a4580c5f
Bugfix: force rendering when the parent’s orientation changed
...
Otherwise, the split indicator might not be refreshed even though it
should be.
fixes #858
2012-10-29 16:41:16 +01:00
9b87b2c8ec
Implement smart popup_during_fullscreen mode
...
With this commit, the default behavior is to display popups while there
is a fullscreen application only if the popup belongs to that
application (as determined by the WM_TRANSIENT_FOR hint which
applications have to set properly).
fixes #663
2012-10-24 20:54:28 +02:00
29b19a7468
spelling error: s/implementaiton/implementation/g
2012-10-24 07:58:03 +02:00
aefcb0b668
Skip floating windows in the focus stack when moving through the tree
...
Includes a test for the new behaviour
2012-10-16 20:03:40 +02:00
fdfbc53c0b
Focus windows when middle-clicking (X paste)
...
As with most click-based focusing, this only has an effect when
focus_follows_mouse is disabled.
2012-10-16 20:03:08 +02:00
c406b4c2fe
Skip floating cons in focus (child|parent) and stop them from being split
...
Focusing child from a workspace should now skip over the floating con and
go directly to its child. Focusing parent from that grandchild should leave
the workspace focused again.
2012-10-16 20:01:36 +02:00
34a5bbb7e9
exit with a proper error message when there are no outputs available (Thanks flo)
...
fixes #842
2012-10-14 20:56:13 +02:00
39ba955919
Bugfix: Actually set border width in config_directives.c (Thanks strcat)
2012-10-09 22:06:36 +02:00
47de7375dd
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-09 21:26:49 +02:00
ca77c12dde
Allow workspace contents to be moved if there are only floating children
2012-10-09 21:25:13 +02:00
e07803999f
Fix fullscreen focus bug and corresponding test flaw
...
As the workspace might be reached via recursion (e.g. moving from the edge
of a fullscreen split container), it's necessary to check for a fullscreen
container whenever a workspace is reached.
2012-10-09 21:24:04 +02:00
7a280f5691
Grab keys with all permutations of lock and numlock
...
This should prevent all cases of caps lock (or shift lock, on some
keyboards) from interfering with i3 key bindings.
2012-10-09 21:15:06 +02:00
00ac2c4c9c
accept ctrl as synonym of control (Thanks SardemFF7)
2012-10-09 14:09:12 +02:00
80492c8304
error out instead of accepting invalid key bindings (Thanks SardemFF7)
2012-10-09 14:09:08 +02:00
ee36c8507e
bugfix: config-parser: bind is a synonym for bindcode
2012-10-08 13:40:44 +02:00
040a441101
fix warning about printf() field length
2012-10-08 13:30:14 +02:00
20c0fa7cfb
use the new parser by default
...
you can force the old parser with the command line flag
--force-old-config-parser-v4.4-only (which will be present in v4.4 only,
as the name suggests)
2012-10-08 13:26:42 +02:00
2738f13798
move owindow definition into the command parser
2012-10-08 13:26:24 +02:00
68e3e58232
link the parser test binaries with -g
2012-10-08 13:25:57 +02:00
c2b699f3dc
change the commands_parser prefix to 'command' for consistency
2012-10-08 13:25:32 +02:00
40c624e1c4
port the entire old config parser to the new one
2012-10-08 13:23:48 +02:00
6f9e6c16c8
config_parser: implement <number>s, proper error handling
2012-10-08 13:23:06 +02:00
00fca2dabd
add first bits of a (custom) config parser
2012-10-08 13:17:46 +02:00
d36264e403
generate-command-parser: make input/output configurable
2012-10-07 16:31:35 +02:00
a6e1b75b18
allow floating cons to be reached using 'focus parent'
...
I suppose this was just an oversight. Let’s see if it causes any issues.
fixes #831
2012-10-04 18:50:33 +02:00
cae6fb627f
Improve startup sequence termination conditions
...
If a window with _NET_STARTUP_ID set is moved to another workspace, it
will delete any associated startup sequence immediately. This will also
occur if a window has a leader with _NET_STARTUP_ID set, if the leader
has no container (never been mapped).
A startup sequence may also be deleted if it's matched by
startup_workspace_for_window() and its 30-second timeout has elapsed.
2012-10-04 17:48:51 +02:00
fdcba7b91a
Replace the discrete 'split' Con property with a simple function.
2012-10-04 17:48:08 +02:00
d7e5da8b39
Un-fullscreen as needed when moving fullscreen containers
...
This avoids a case where a fullscreen container could be moved onto a
workspace that already had its own fullscreen container, leading to
two fullscreen containers on top of each other.
2012-10-04 17:46:54 +02:00
2eeb2a1067
shmlog: Remove O_TRUNC flag for shm_open, we truncate ourselves
2012-10-04 17:05:08 +02:00
13147978c5
Merge branch 'master' into next
2012-10-03 15:08:31 +02:00
507898484f
set workspace_layout in create_workspace_on_output
...
fixes #835
2012-10-03 15:08:21 +02:00
f89bbe0746
Focus the relevant workspace when clicking any container.
2012-10-03 00:15:55 +02:00
f4b09862fc
Maintain relative positioning when moving floating windows between outputs.
2012-10-03 00:14:57 +02:00
a9d859f84e
Only re-focus the workspace when moving a con if the target ws is hidden.
2012-10-03 00:03:24 +02:00
e89a25f81f
Implement moving workspaces as if they're regular containers
2012-09-29 00:17:36 +02:00
72c66a2091
Merge branch 'master' into next
2012-09-29 00:03:42 +02:00
31e8d7f2f8
Bugfix: Correctly move floating windows to invisible workspaces cross-output (Thanks swh)
2012-09-29 00:02:41 +02:00
43d486441d
Bugfix: with one ws per output, don’t crash on cross-output moves (Thanks moju)
...
fixes #827
2012-09-28 23:04:37 +02:00
66b389cba1
Make the resize command honor criteria (Thanks Tblue)
...
fixes #816
2012-09-28 20:36:25 +02:00
2252b4f5b9
Merge branch 'master' into next
2012-09-28 19:47:16 +02:00
a082cf8c65
Bugfix: Draw h-split indicator at the right position
...
fixes #817
2012-09-28 19:46:50 +02:00
5d8e3f58f6
Fix 'border toggle' (it "skipped" 1px border) (Thanks joepd)
...
fixes #818
2012-09-28 19:29:14 +02:00
cd2a1267c8
Merge branch 'master' into next
2012-09-28 18:24:04 +02:00
8480b4cb58
Bugfix: don’t crash when dragged floating window closes (Thanks darkraven)
...
Previously, while the loop would not be executed anymore, the callback
(for actually repositioning the window after a MotionNotify) would still
get called once. This commit avoids that, thus fixing the crash.
fixes #819
2012-09-28 18:23:01 +02:00
da2b47c1e5
fix crash: send non-floating window with floating parent to scratchpad (thanks pkordy)
...
Fix a crash that occured when moving a window to the scratchpad that is
seemingly floating to the user, but actually a descendant of a floating
parent con (and itself non-floating). If that is the case, move the
floating parent container to scratchpad instead of the window.
fixes #740
2012-09-28 17:58:58 +02:00
584a6b6b59
Revert "raise floating windows when focusing (Thanks Marcos)"
...
This commit breaks floating window keyboard focus order
(t/135-floating-focus.t) when you have > 2 floating windows. Since
keyboard focus is more important than saving one click to raise floating
windows, I revert the commit.
Note that we cannot implement this without keeping a third list (beneath
floating_windows and focus) for the z coordinate of a floating window.
This seems not worth it.
This reverts commit 064be457e5
2012-09-28 17:57:17 +02:00
064be457e5
raise floating windows when focusing (Thanks Marcos)
2012-09-27 12:41:38 +02:00
1cbf665581
remove async-unsafe functions from signal handler
2012-09-27 12:37:27 +02:00
9c01bdeef7
Revert "Use ev_signal to avoid async-unsafe functions (Thanks Markus)"
...
This makes our signal handler useless and leads to infinite SIGSEGV
loops because the ev callback handler gets called only from within the
event loop, and control doesn’t necessary get to the event loop…
This reverts commit 514265b529
2012-09-27 12:34:09 +02:00
87525ad2d6
fix crash: urgent floating con on separate workspace (thanks Piotr)
...
If there is a single floating con on a separate workspace that is not
focused, and this con becomes urgent, switching back to that workspace
may result in a crash of i3. This is because while setting the urgency
of parent containers, 'parent' may become NULL in case of floating
containers. This commit checks the validity of parent.
fixes #821
2012-09-27 12:21:18 +02:00
Michael Stapelberg