Commit Graph

5776 Commits

Author SHA1 Message Date
Ingo Bürk b23f23b29b Merge pull request #2836 from acrisci/bug/sysconfdir-to-makefile
Move SYSCONFDIR definition to makefile
2017-07-13 06:55:22 +02:00
Ingo Bürk 0016ee8366 Merge pull request #2838 from acrisci/bug/colors-only-hex
Ensure colors are in hex
2017-07-13 06:50:05 +02:00
Tony Crisci 3a914396df libi3: Add basic validation to hex color conversion
Make sure a given hex color is the expected length and begins with a hash in
draw_util_hex_to_color() to avoid memory errors.

fixes #2829
2017-07-12 17:53:15 -04:00
Tony Crisci 1c06f8b797 i3bar: change error block color to hex
Named colors are not supported by the i3bar protocol so give the error block
color in hex.
2017-07-12 17:53:15 -04:00
Tony Crisci c534a3ea95 Move SYSCONFDIR definition to makefile
Official autoconf docs contraindicate the use of the $sysconfdir
variable in configure.ac. For reference:

https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Installation-Directory-Variables.html

The macro SYSCONFDIR (ordinarilly set to "/etc") is required to find
a system configuration file installed with i3. In some build setups,
this may not be defined properly in when the configure script is
compiled.

Instead, define this variable in AM_CPPFLAGS as the documentation
indicates.

fixes #2832
2017-07-12 10:57:23 -04:00
Ingo Bürk bf1e4339e6 Merge pull request #2831 from dvejmz/next
Add KDE konsole terminal fallback to i3-sensible-terminal
2017-07-11 16:06:45 +02:00
David Jimenez Sequero cacd2ae600 Add KDE konsole terminal fallback to i3-sensible-terminal 2017-07-10 12:27:31 +01:00
Ingo Bürk cea7d135a5 Merge pull request #2827 from akash-akya/next
Fix 'Mouse binding don't work'
2017-07-09 13:23:42 +02:00
akash akya ec3ffdd7a0 Fix 'Mouse binding don't work' 2017-07-07 01:03:36 +05:30
Ingo Bürk 2a918169f2 Merge pull request #2820 from hwangcc23/fix-2804
i3-msg: Return an exit code upon missing -t arg
2017-06-23 08:31:08 +02:00
hwangcc23 5362876b60 i3-msg: Return an exit code upon missing -t arg
If getopt() returns '?' (option with a missing argument), exit the program with an error code rather than continuing the execution.

Fix the issue #2804 (https://github.com/i3/i3/issues/2804).
2017-06-22 22:53:08 +08:00
Ingo Bürk 78adcdab7f Merge pull request #2808 from hwangcc23/fix-2802
Fix 'rename workspace to tosomething'
2017-06-13 15:15:49 +02:00
hwangcc23 cc4be41674 Fix 'rename workspace to tosomething'
This patch fixes the issue #2802 (https://github.com/i3/i3/issues/2802).

1). Revise the state machine for the 'rename workspace' command.
    These scenarios are considered:
    a). 'rename workspace to to bla'
        state transitions: RENAME -> RENAME_WORKSPACE -> RENAME_WORKSPACE_LIKELY_TO -> RENAME_WORKSPACE_LIKELY_TO_NEW_NAME
    b). 'rename workspace to tosomething'
        state transitions: RENAME -> RENAME_WORKSPACE -> RENAME_WORKSPACE_LIKELY_TO
    c). 'rename workspace to to'
        state transitions: RENAME -> RENAME_WORKSPACE -> RENAME_WORKSPACE_LIKELY_TO
    d). 'rename workspace to bla'
        state transitions: RENAME -> RENAME_WORKSPACE -> RENAME_WORKSPACE_LIKELY_TO
    e). 'rename workspace bla to foo'
        state transitions: RENAME -> RENAME_WORKSPACE -> RENAME_WORKSPACE_TO -> RENAME_WORKSPACE_TO_NEW_NAME

2). Add a test case in 117-workspace.t for the scenario b.
2017-06-12 22:21:21 +08:00
Ingo Bürk e8f86832ee Merge pull request #2795 from Adaephon-GH/doc-config-load-order
Fix manpage on configuration lookup order
2017-06-12 11:01:58 +02:00
Ingo Bürk 4a66407602 Merge pull request #2799 from hwangcc23/add_compilation_inst
Add compilation instructions to the hacking howto
2017-06-12 11:00:28 +02:00
hwangcc23 e63070607f Add compilation instructions to the hacking howto 2017-06-03 23:21:42 +08:00
Ingo Bürk d3901fe92e Merge pull request #2796 from Armael/next
Add a link to the ocaml-i3ipc library
2017-05-31 20:33:39 +02:00
Armaël Guéneau b2ee718f56 Add a link to the ocaml-i3ipc library 2017-05-31 16:53:33 +02:00
Adaephon-GH ca1b0afca1 Fix manpage on configuration lookup order
The lookup order stated in the i3 manpage was is contratiction to the
actual lookup order, which was introduced with commit
bfa12a5819.
Since that commit (6.5 years ago) the "traditional" paths took precedence
over XDG_CONFIG paths.
2017-05-31 11:26:07 +02:00
Ingo Bürk a7e8c4dd46 Merge pull request #2772 from loungecube/patch-1
prevent multiple menu items per .desktop entry
2017-05-29 08:37:44 +02:00
Ingo Bürk 29f5b37841 Merge pull request #2784 from stapelberg/numrelease
compare modifiers for equality, not subset
2017-05-24 21:43:33 +02:00
Michael Stapelberg a4f6387911 compare modifiers for equality, not subset (+test)
Subset comparison was introduced with the rather large commit
bf3cd41b5d, but I now think we should use
equality.

In other words, the following key binding:

    bindsym Mod4+x nop Mod4+x

previously would have been triggered when pressing Mod3+Mod4+x.

Strictly speaking, this is a change of behavior, but it breaks none of our
tests, and using equality instead of subset comparison enables more use-cases.

fixes #2002
2017-05-24 20:42:27 +02:00
Michael Stapelberg 26f5edb97f no-op change: store |button| in the correct data type 2017-05-24 20:41:55 +02:00
Michael Stapelberg 0acd11a8d7 no-op change: move bind->release check into loop
We don’t have to negate the check anymore, making it more readable.
2017-05-24 20:41:17 +02:00
Michael Stapelberg 6d9b165fb4 no-op change: don’t compare keycode for every modifier 2017-05-24 20:40:17 +02:00
Chih-Chyuan Hwang 13372d511a Fix the i3 crash caused by mark + restart commands (#2779)
This patch fixes the issue #2511(https://github.com/i3/i3/issues/2511).

1). Memorize the marks, but only call con_mark once the container has finished parsing. (Credit: This is @Airblader's patch.)

2). Add a test case 267-regress-mark-restart.t for regression test to check if mark and restart command crash i3.
2017-05-23 08:47:11 +02:00
Ingo Bürk 990100317a Merge pull request #2782 from stapelberg/release-bindings
Fix --release bindings broken by previous commit
2017-05-23 08:40:05 +02:00
Michael Stapelberg 2bd3639fbb Fix --release bindings broken by previous commit
fixes #2559
2017-05-23 08:28:56 +02:00
Michael Stapelberg 36f80f2de8 Apply numlock fallback to bindcode where necessary (#2781)
This was broken with commit d77d40173a

fixes #2559
2017-05-22 21:32:05 +02:00
Ingo Bürk 5fc00e2d18 Merge pull request #2777 from hwangcc23/update-testsuite-doc
Update testsuite docs
2017-05-22 08:50:58 +02:00
hwangcc23 bbfdcfddfe Update testsuite docs
After moved to autotools, the method to run the i3 testsuite is changed.
Update the testsuite document to reflect the change.
2017-05-21 23:08:27 +08:00
Ingo Bürk 305cb871df Merge pull request #2773 from lasers/next
docs/ipc: Fix typo
2017-05-18 09:51:45 +02:00
lasers e4c2eb12ae docs/ipc: Fix typo 2017-05-17 18:48:56 -05:00
Ingo Bürk aa8556abfc Merge pull request #2761 from mdirkse/next
[WIP] Change golang ipc lib reference to one that is maintained.
2017-05-17 10:39:42 +02:00
Ingo Bürk 7b6f592b71 Merge pull request #2771 from hwangcc23/fix-2764
Support to get the primary output
2017-05-16 18:39:37 +02:00
hwangcc23 f99727b518 Support to get the primary output
This makes `primary` output available for assign or move commands.
Fix the issue #2764(https://github.com/i3/i3/issues/2764).
2017-05-16 23:06:12 +08:00
Michael Stapelberg 6dd4252cd5 Merge pull request #2496 from Airblader/feature-917
Implement 'swap' command.
2017-05-15 21:35:10 +02:00
Ingo Bürk 5f9a5e8d7d Implement 'swap' command.
This patch introduces a new command 'swap' that swaps two containers so
that they assume each other's position and geometry.

fixes #917
2017-05-15 21:06:38 +02:00
loungecube 838616a165 prevent multiple menu items per .desktop entry
If a .desktop entry is being added to the list of Menu items by its "Name" field, it should not be added again by its command or filename.
If it is being added by its command, it should not be added again by its filename.
2017-05-15 05:02:09 +02:00
Ingo Bürk 9178c5b8ca Force container to be redrawn upon moving to another container. (#2769)
This is necessary as otherwise urgent containers can be broken
after moving them.
2017-05-12 19:26:35 +02:00
Ingo Bürk 38827fbb7e Merge pull request #2766 from MachFour/nagbar-shell-exec
i3-nagbar: add button flag to execute action with /bin/sh directly
2017-05-12 15:39:40 +02:00
Max Fisher 2fe9d7bbd2 i3-nagbar: add button flag to execute action with /bin/sh directly.
Fixes #2765.
2017-05-12 21:50:41 +10:00
Nathan Schulte 9bc504ebdb add error check and log for xcb_create_window 2017-05-12 09:01:37 +02:00
Ingo Bürk b56cb84e16 Added a hint about the required config v4 version hint. (#2759)
fixes #2751
2017-05-04 23:08:51 +02:00
Ingo Bürk 333ebd7b71 Merge pull request #2762 from mdirkse/valid_json
Fix invalid JSON
2017-05-04 15:23:15 +02:00
Maarten Dirkse e428bf02fb Fix invalid JSON 2017-05-04 00:36:44 +02:00
Maarten Dirkse a3c6a89e6e Change golang ipc lib reference to one that is maintained. 2017-05-02 13:12:25 +02:00
Ingo Bürk 2dc13211a5 Merge pull request #2757 from Jereq/next
Fix i3-dmenu-desktop quoted command name
2017-05-02 10:06:00 +02:00
Ingo Bürk c826fc0e44 Query workspaces again in i3bar when an output change occured. (#2760)
As of 2f0f8b1, i3bar will properly clean up on output change events.
However, this requires us to query the workspaces again to avoid a
display error in i3bar.

fixes #2740
fixes #2743
2017-05-02 09:11:35 +02:00
Ingo Bürk d78fd8d91f Introduce --exclude-titlebar flag for mouse bindings. (#2703)
This introduces the flag --exclude-titlebar for mouse bindings which
allows bindings like

    bindsym --whole-window --border --exclude-titlebar button3 focus

fixes #2347
2017-05-02 09:08:42 +02:00