0b62129224
Remove unused headers
...
With help from
https://github.com/include-what-you-use/include-what-you-use/
2020-04-20 04:25:06 +02:00
3c522d9f2f
Sort includes in *.c files
...
Not enabling in .clang-format because it breaks headers files.
Used:
IncludeCategories:
- Regex: '^<config'
Priority: 0
- Regex: '^".*"'
Priority: 1
- Regex: '^<(xcb|xkb|yajl|X11)'
Priority: 3
- Regex: '.*'
Priority: 2
2020-04-19 09:58:25 +02:00
0bce0d86bf
Merge pull request #4018 from orestisfl/reorder-docks
...
Sort dock clients by class and instance
2020-04-15 08:36:10 +02:00
7df88f18eb
Sort dock clients by class and instance
...
This is similar to #3820 but does not use qsort but an insertion sort in
con_attach.
Since each bar block automatically gets its own incremental bar id,
bards end up being sorted according to their definition order in the
config file.
For i3bar, the WM_CLASS is modified to include an instance name which
depends on the bar_id. This could be useful for other reason, e.g. users
targeting a specific bar instance.
Fixes #3491
2020-04-14 20:47:51 +02:00
831a52de9a
Move content for non-existing output containers ( #3767 )
...
Probably fixes various related issues:
Closes #2276
Closes #2459
Closes #2936
Closes #3766
Tested using
bindsym $mod+Shift+i exec xrandr --output DVI-D-0 --mode 1920x1080 --pos 0x0 --rotate normal --output DVI-I-1 --off, restart
The core issue here is that the JSON read during a restart might contain
invalid outputs when the new process is done reading it.
2020-04-12 13:52:05 +02:00
ae757c6848
Extend tiling/floating criteria with optional auto/user values ( #4006 )
...
The default `tiling` and `floating` behavior is preserved and matches
both cases.
Adds a new handler to `remanage_window` on A_I3_FLOATING_WINDOW change.
Mainly in order to `run_assignments`, this makes `for_window [floating]`
directives to work for windows which where initially opened as tiling.
Now, when floating is enabled, `for_window` will trigger correctly. Same
applies to `for_window [tiling]`.
The obvious solution of `run_assignments` after
`floating_{enable,disable}` doesn't work because `run_assignments`
modifies the parser state in src/assignments.c:51.
Fixes #3588
Co-Authored-By: Michael Stapelberg <michael@stapelberg.de>
2020-04-12 13:49:08 +02:00
a87e8c8d5b
Fix load_layout crash when floating node doesn't have CT_FLOATING_CON parent
...
Fixes #3901
2020-04-12 00:48:01 +02:00
62279aba45
Merge pull request #4005 from orestisfl/route_click_clutter
...
route_click readability improvements
2020-04-11 19:51:00 +02:00
f4b1da7f23
Merge pull request #4011 from orestisfl/floating_reposition-needs_tree_render
...
Call tree_render if floating move changes workspace
2020-04-11 19:50:14 +02:00
93bb2022bb
Merge pull request #4012 from orestisfl/floating_maybe_reassign_ws_focus
...
floating_maybe_reassign_ws: only re-focus if previously focused
2020-04-11 19:49:53 +02:00
e47d5f6a3e
Merge pull request #4008 from orestisfl/limit-run_command-LOG
...
Limit log length with IPC commands
2020-04-11 19:49:24 +02:00
1e9fbd7186
Merge pull request #4010 from orestisfl/trailing-whitespace-log
...
Fix trailing whitespace in a DLOG
2020-04-11 19:49:05 +02:00
5eab604a10
floating_maybe_reassign_ws: only re-focus if previously focused
...
Fixes #3979
2020-04-11 11:10:51 +02:00
755d306df3
Revert "floating_reposition: avoid extra tree_render"
...
This reverts commit 204eefc679
2020-04-11 11:08:55 +02:00
bb8f2927ae
Call tree_render if floating move changes workspace
...
This fixes a bug where moving a floating container with
cmd_move_direction displays a "broken" state if the container crosses
workspace boundaries.
2020-04-11 10:52:35 +02:00
e4cfb80a05
Fix trailing whitespace in a DLOG
2020-04-11 10:10:44 +02:00
964456b628
Limit log length with IPC commands
...
Fixes #3525
2020-04-10 16:59:46 +02:00
57a37f8af4
run_command: Update outdated docstring
2020-04-10 16:41:36 +02:00
b247896a75
Move parent nodes in scratchpad correctly ( #3793 )
...
* Move parent nodes in scratchpad across workspaces
Co-Authored-By: Orestis <orestisflo@gmail.com>
2020-04-10 16:27:40 +02:00
312d3dfbd3
Merge pull request #4003 from orestisfl/update_desktop_properties_on_move
...
Update EWMH properties on workspace move
2020-04-10 14:00:26 +02:00
58d383b1a0
route_click: Remove condition that is always true
...
For reference:
typedef enum { CLICK_BORDER = 0,
CLICK_DECORATION = 1,
CLICK_INSIDE = 2 } click_destination_t;
2020-04-10 12:24:18 +02:00
07c7384272
route_click: Add some const bools for readability
2020-04-10 12:22:24 +02:00
b401cc994b
Merge pull request #3954 from xzfc/floating-tiling-resize
...
Make floating-tiling resize code consistent with plain tiling resize
2020-04-10 12:17:26 +02:00
59108ec299
Merge pull request #3816 from sandsmark/martin/empty-matches
...
Match empty window properties (e. g. no title set) #3308
2020-04-10 11:44:46 +02:00
ed67eaca2c
Update EWMH properties on workspace move
...
Closes #3965
Fixes #4001
2020-04-10 04:40:11 +02:00
c46fdc8363
Merge pull request #3995 from xzfc/refactor-property-handlers
...
Refactor property handlers
2020-04-10 03:58:12 +02:00
6fa2cd32a0
handle_button_press and route_click do not need to return int
2020-04-09 16:16:30 +02:00
93e96f4e6b
Do not propagate $mod+right click to clients
2020-04-09 16:08:41 +02:00
b590ca076c
Avoid resizing fullscreen container with non-fullscreen
...
Another option is to modify resize_find_tiling_participants but this
would also affect resizing of tiling containers in scripts, so I chose
to make this change specific to resizing with the mouse.
Follow-up after #3983
Fixes #3980
2020-04-09 15:49:09 +02:00
4922b245c1
Revert "Avoid resizing fullscreen container"
...
This reverts commit 1a2882d740https://github.com/i3/i3/issues/3980#issuecomment-611515497 , this
disables resizing children of fullscreen containers.
2020-04-09 15:11:46 +02:00
4b4f1f604f
cmd_focus_sibling: Fix crash on workspace level
...
Fixes #3997
2020-04-09 11:29:14 +02:00
d9d366a656
handlers.c: cb_property_handler_t: take Con instead of xcb_window_t
...
Since every handler calls con_by_window_id() and checks for NULL, it is
better to move this call into property_notify().
2020-04-08 08:37:40 +00:00
e03fdef3e5
handlers.c: property_notify(): DLOG and return in case of an error
2020-04-08 08:37:40 +00:00
5716ff541f
handlers.c: remove redundant property fetching
...
Some property handlers trying to fetch property again if `prop == NULL`.
This is redundant since these properties are either fetched by
property_notify() just before or deleted.
2020-04-08 08:37:40 +00:00
148ff54f18
handlers.c: remove unused arguments from cb_property_handler_t
...
Also, use `conn` global variable instead of passing it as an argument.
2020-04-08 08:02:17 +00:00
1a2882d740
Avoid resizing fullscreen container
...
Fixes #3980
2020-03-31 08:52:53 +02:00
d02cda4241
ipc: always include marks property in TREE reply
2020-03-07 11:12:47 +00:00
47be36410c
Assume xcb_cursor_context_new never fails ( #3955 )
...
According to libxcb-cursor code, the only condition in which
xcb_cursor_context_new() returns a non-zero result is a memory
allocation failure[1]. Thus, it is safe to assume that
xcursor_supported is always true, and remove dead code.
[1]: https://gitlab.freedesktop.org/xorg/lib/libxcb-cursor/blob/0.1.3/cursor/cursor.c#L131-132
2020-02-24 08:48:58 +01:00
d36829d6e2
Make floating-tiling resize code consistent with plain tiling resize
...
Now dragging an inner border of a floating split triggers a tiling
resize (as expected) instead of a floating resize.
2020-02-22 23:35:55 +00:00
b98b055459
i3 --moreversion: erase the line before writing over
...
The trailing part of the line (`abort…)`) has often been appearing in
bug reports.
2020-02-21 02:07:23 +00:00
83c7aff089
Limit workspace numbers within 0..INT32_MAX
...
Before this commit, large workspace numbers treated oddly:
$ i3-msg 'rename workspace to 1234567890'
# displayed in i3bar as `0`
$ i3-msg 'rename workspace to 4294967200'
$ i3-msg -t get_workspaces | jq '.[]|select(.focused).num'
-96 # int32_t overflow
$ i3-msg 'rename workspace to 99999999999999999999'
$ i3-msg -t get_workspaces | jq '.[]|select(.focused).num'
-1 # treated as unnumbered
This commit puts a consistent limit on workspace numbers. Now
workspaces with numbers beyond INT32_MAX are treated as unnumbered.
2020-02-21 02:07:04 +00:00
d3976fee8c
Code style: fix misaligned and trailing whitespaces
2020-02-21 02:06:48 +00:00
670c23600f
Decoration click/mouse move: iterate children in reverse order
...
In the case of decoration overlap, we should handle the one that is
drawn on top, i.e., the last one.
2020-02-19 11:33:49 +01:00
e6ca7ca06f
Sanitize con and window rect dimensions
...
Make sure they're neither zero (prohibited by X11) nor overflown during
subtraction.
2020-02-19 11:33:49 +01:00
1f0c628cde
clang-format: bring back ForeachMacros ( #3948 )
...
* clang-format: bring back ForeachMacros
ForeachMacros was disabled in 4211274fcd
2020-02-19 11:31:09 +01:00
e3f120c0b6
Merge pull request #3946 from phy1729/i3bar_command-exec
...
Prepend "exec " to default i3bar_command
2020-02-18 09:16:27 +01:00
f517b5aa57
Merge pull request #3918 from orestisfl/fno-common
...
Fix fno-common problems with gcc10
2020-02-15 12:25:58 +01:00
2eac53fada
atoms: Properly declare as global variables
...
See #3914
2020-02-01 17:34:01 +01:00
d11e862919
Delete duplicate definition of ewmh_window
...
See #3914
2020-02-01 17:32:53 +01:00
a2cba79f9c
Prepend "exec " to default i3bar_command
...
Avoids leaving around a useless shell process.
2020-01-30 21:02:50 -06:00
Orestis Floros