2010-03-27 15:25:51 +01:00
|
|
|
|
/*
|
|
|
|
|
* vim:ts=4:sw=4:expandtab
|
2011-10-23 00:40:02 +02:00
|
|
|
|
*
|
|
|
|
|
* i3 - an improved dynamic tiling window manager
|
2015-04-04 02:17:56 +02:00
|
|
|
|
* © 2009 Michael Stapelberg and contributors (see also: LICENSE)
|
2011-10-23 00:40:02 +02:00
|
|
|
|
*
|
|
|
|
|
* x.c: Interface to X11, transfers our in-memory state to X11 (see also
|
|
|
|
|
* render.c). Basically a big state machine.
|
|
|
|
|
*
|
2010-03-27 15:25:51 +01:00
|
|
|
|
*/
|
|
|
|
|
#include "all.h"
|
|
|
|
|
|
2016-03-08 02:40:02 +01:00
|
|
|
|
#ifndef MAX
|
|
|
|
|
#define MAX(x, y) ((x) > (y) ? (x) : (y))
|
|
|
|
|
#endif
|
|
|
|
|
|
2015-09-12 22:34:06 +02:00
|
|
|
|
xcb_window_t ewmh_window;
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/* Stores the X11 window ID of the currently focused window */
|
2011-03-20 16:26:36 +01:00
|
|
|
|
xcb_window_t focused_id = XCB_NONE;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2014-09-20 23:21:08 +02:00
|
|
|
|
/* Because 'focused_id' might be reset to force input focus, we separately keep
|
|
|
|
|
* track of the X11 window ID to be able to always tell whether the focused
|
|
|
|
|
* window actually changed. */
|
2014-02-22 11:52:01 +01:00
|
|
|
|
static xcb_window_t last_focused = XCB_NONE;
|
|
|
|
|
|
2011-08-12 03:54:59 +02:00
|
|
|
|
/* Stores coordinates to warp mouse pointer to if set */
|
|
|
|
|
static Rect *warp_to;
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/*
|
|
|
|
|
* Describes the X11 state we may modify (map state, position, window stack).
|
|
|
|
|
* There is one entry per container. The state represents the current situation
|
|
|
|
|
* as X11 sees it (with the exception of the order in the state_head CIRCLEQ,
|
|
|
|
|
* which represents the order that will be pushed to X11, while old_state_head
|
|
|
|
|
* represents the current order). It will be updated in x_push_changes().
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
typedef struct con_state {
|
|
|
|
|
xcb_window_t id;
|
|
|
|
|
bool mapped;
|
2011-07-04 13:41:02 +02:00
|
|
|
|
bool unmap_now;
|
2010-11-28 22:08:34 +01:00
|
|
|
|
bool child_mapped;
|
2015-04-16 19:43:23 +02:00
|
|
|
|
bool is_hidden;
|
2010-09-01 18:11:01 +02:00
|
|
|
|
|
2011-08-03 20:07:03 +02:00
|
|
|
|
/** The con for which this state is. */
|
|
|
|
|
Con *con;
|
|
|
|
|
|
2010-09-01 18:11:01 +02:00
|
|
|
|
/* For reparenting, we have a flag (need_reparent) and the X ID of the old
|
|
|
|
|
* frame this window was in. The latter is necessary because we need to
|
|
|
|
|
* ignore UnmapNotify events (by changing the window event mask). */
|
|
|
|
|
bool need_reparent;
|
|
|
|
|
xcb_window_t old_frame;
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
Rect rect;
|
|
|
|
|
Rect window_rect;
|
|
|
|
|
|
|
|
|
|
bool initial;
|
|
|
|
|
|
2010-11-14 16:41:46 +01:00
|
|
|
|
char *name;
|
|
|
|
|
|
2016-11-08 22:46:43 +01:00
|
|
|
|
CIRCLEQ_ENTRY(con_state)
|
|
|
|
|
state;
|
|
|
|
|
|
|
|
|
|
CIRCLEQ_ENTRY(con_state)
|
|
|
|
|
old_state;
|
|
|
|
|
|
|
|
|
|
TAILQ_ENTRY(con_state)
|
|
|
|
|
initial_mapping_order;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
} con_state;
|
|
|
|
|
|
2016-11-08 22:46:43 +01:00
|
|
|
|
CIRCLEQ_HEAD(state_head, con_state)
|
|
|
|
|
state_head =
|
2010-03-27 15:25:51 +01:00
|
|
|
|
CIRCLEQ_HEAD_INITIALIZER(state_head);
|
|
|
|
|
|
2016-11-08 22:46:43 +01:00
|
|
|
|
CIRCLEQ_HEAD(old_state_head, con_state)
|
|
|
|
|
old_state_head =
|
2010-03-27 15:25:51 +01:00
|
|
|
|
CIRCLEQ_HEAD_INITIALIZER(old_state_head);
|
|
|
|
|
|
2016-11-08 22:46:43 +01:00
|
|
|
|
TAILQ_HEAD(initial_mapping_head, con_state)
|
|
|
|
|
initial_mapping_head =
|
2014-04-08 20:27:40 +02:00
|
|
|
|
TAILQ_HEAD_INITIALIZER(initial_mapping_head);
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/*
|
|
|
|
|
* Returns the container state for the given frame. This function always
|
|
|
|
|
* returns a container state (otherwise, there is a bug in the code and the
|
|
|
|
|
* container state of a container for which x_con_init() was not called was
|
|
|
|
|
* requested).
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
static con_state *state_for_frame(xcb_window_t window) {
|
|
|
|
|
con_state *state;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH(state, &state_head, state)
|
|
|
|
|
if (state->id == window)
|
|
|
|
|
return state;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
|
|
|
|
/* TODO: better error handling? */
|
|
|
|
|
ELOG("No state found\n");
|
2010-05-31 23:08:16 +02:00
|
|
|
|
assert(false);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Initializes the X11 part for the given container. Called exactly once for
|
|
|
|
|
* every container from con_new().
|
|
|
|
|
*
|
|
|
|
|
*/
|
2016-05-05 14:18:27 +02:00
|
|
|
|
void x_con_init(Con *con) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/* TODO: maybe create the window when rendering first? we could then even
|
|
|
|
|
* get the initial geometry right */
|
|
|
|
|
|
|
|
|
|
uint32_t mask = 0;
|
2012-01-28 17:09:02 +01:00
|
|
|
|
uint32_t values[5];
|
|
|
|
|
|
2016-05-05 14:18:27 +02:00
|
|
|
|
xcb_visualid_t visual = get_visualid_by_depth(con->depth);
|
2016-09-14 09:13:17 +02:00
|
|
|
|
xcb_colormap_t win_colormap;
|
|
|
|
|
if (con->depth != root_depth) {
|
|
|
|
|
/* We need to create a custom colormap. */
|
|
|
|
|
win_colormap = xcb_generate_id(conn);
|
|
|
|
|
xcb_create_colormap(conn, XCB_COLORMAP_ALLOC_NONE, win_colormap, root, visual);
|
|
|
|
|
con->colormap = win_colormap;
|
|
|
|
|
} else {
|
|
|
|
|
/* Use the default colormap. */
|
|
|
|
|
win_colormap = colormap;
|
|
|
|
|
con->colormap = XCB_NONE;
|
|
|
|
|
}
|
2015-11-17 12:50:06 +01:00
|
|
|
|
|
|
|
|
|
/* We explicitly set a background color and border color (even though we
|
|
|
|
|
* don’t even have a border) because the X11 server requires us to when
|
|
|
|
|
* using 32 bit color depths, see
|
|
|
|
|
* http://stackoverflow.com/questions/3645632 */
|
|
|
|
|
mask |= XCB_CW_BACK_PIXEL;
|
|
|
|
|
values[0] = root_screen->black_pixel;
|
|
|
|
|
|
|
|
|
|
mask |= XCB_CW_BORDER_PIXEL;
|
|
|
|
|
values[1] = root_screen->black_pixel;
|
|
|
|
|
|
|
|
|
|
/* our own frames should not be managed */
|
|
|
|
|
mask |= XCB_CW_OVERRIDE_REDIRECT;
|
|
|
|
|
values[2] = 1;
|
|
|
|
|
|
|
|
|
|
/* see include/xcb.h for the FRAME_EVENT_MASK */
|
|
|
|
|
mask |= XCB_CW_EVENT_MASK;
|
|
|
|
|
values[3] = FRAME_EVENT_MASK & ~XCB_EVENT_MASK_ENTER_WINDOW;
|
|
|
|
|
|
|
|
|
|
mask |= XCB_CW_COLORMAP;
|
|
|
|
|
values[4] = win_colormap;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2014-06-15 19:07:02 +02:00
|
|
|
|
Rect dims = {-15, -15, 10, 10};
|
2016-05-05 14:18:27 +02:00
|
|
|
|
xcb_window_t frame_id = create_window(conn, dims, con->depth, visual, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCURSOR_CURSOR_POINTER, false, mask, values);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_surface_init(conn, &(con->frame), frame_id, get_visualtype_by_id(visual), dims.width, dims.height);
|
2015-09-22 00:01:36 +02:00
|
|
|
|
xcb_change_property(conn,
|
|
|
|
|
XCB_PROP_MODE_REPLACE,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
con->frame.id,
|
2015-09-22 00:01:36 +02:00
|
|
|
|
XCB_ATOM_WM_CLASS,
|
|
|
|
|
XCB_ATOM_STRING,
|
|
|
|
|
8,
|
|
|
|
|
(strlen("i3-frame") + 1) * 2,
|
|
|
|
|
"i3-frame\0i3-frame\0");
|
2012-03-01 06:53:06 +01:00
|
|
|
|
|
2015-08-03 11:50:13 +02:00
|
|
|
|
struct con_state *state = scalloc(1, sizeof(struct con_state));
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
state->id = con->frame.id;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
state->mapped = false;
|
|
|
|
|
state->initial = true;
|
2014-04-08 20:27:40 +02:00
|
|
|
|
DLOG("Adding window 0x%08x to lists\n", state->id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
CIRCLEQ_INSERT_HEAD(&state_head, state, state);
|
|
|
|
|
CIRCLEQ_INSERT_HEAD(&old_state_head, state, old_state);
|
2014-04-08 20:27:40 +02:00
|
|
|
|
TAILQ_INSERT_TAIL(&initial_mapping_head, state, initial_mapping_order);
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("adding new state for window id 0x%08x\n", state->id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
2010-04-17 16:41:20 +02:00
|
|
|
|
/*
|
|
|
|
|
* Re-initializes the associated X window state for this container. You have
|
|
|
|
|
* to call this when you assign a client to an empty container to ensure that
|
|
|
|
|
* its state gets updated correctly.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void x_reinit(Con *con) {
|
|
|
|
|
struct con_state *state;
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((state = state_for_frame(con->frame.id)) == NULL) {
|
2010-04-17 16:41:20 +02:00
|
|
|
|
ELOG("window state not found\n");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("resetting state %p to initial\n", state);
|
2010-04-17 16:41:20 +02:00
|
|
|
|
state->initial = true;
|
2010-11-28 22:08:34 +01:00
|
|
|
|
state->child_mapped = false;
|
2011-08-03 20:07:03 +02:00
|
|
|
|
state->con = con;
|
2010-04-17 16:41:20 +02:00
|
|
|
|
memset(&(state->window_rect), 0, sizeof(Rect));
|
|
|
|
|
}
|
|
|
|
|
|
2010-09-01 18:11:01 +02:00
|
|
|
|
/*
|
|
|
|
|
* Reparents the child window of the given container (necessary for sticky
|
|
|
|
|
* containers). The reparenting happens in the next call of x_push_changes().
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void x_reparent_child(Con *con, Con *old) {
|
|
|
|
|
struct con_state *state;
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((state = state_for_frame(con->frame.id)) == NULL) {
|
2010-09-01 18:11:01 +02:00
|
|
|
|
ELOG("window state for con not found\n");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
state->need_reparent = true;
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
state->old_frame = old->frame.id;
|
2010-09-01 18:11:01 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Moves a child window from Container src to Container dest.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void x_move_win(Con *src, Con *dest) {
|
|
|
|
|
struct con_state *state_src, *state_dest;
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((state_src = state_for_frame(src->frame.id)) == NULL) {
|
2010-09-01 18:11:01 +02:00
|
|
|
|
ELOG("window state for src not found\n");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((state_dest = state_for_frame(dest->frame.id)) == NULL) {
|
2010-09-01 18:11:01 +02:00
|
|
|
|
ELOG("window state for dest not found\n");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-08-03 20:07:03 +02:00
|
|
|
|
state_dest->con = state_src->con;
|
|
|
|
|
state_src->con = NULL;
|
|
|
|
|
|
2014-06-15 19:07:02 +02:00
|
|
|
|
Rect zero = {0, 0, 0, 0};
|
2010-09-01 18:11:01 +02:00
|
|
|
|
if (memcmp(&(state_dest->window_rect), &(zero), sizeof(Rect)) == 0) {
|
|
|
|
|
memcpy(&(state_dest->window_rect), &(state_src->window_rect), sizeof(Rect));
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("COPYING RECT\n");
|
2010-09-01 18:11:01 +02:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-07-13 11:35:05 +02:00
|
|
|
|
/*
|
|
|
|
|
* Kills the window decoration associated with the given container.
|
|
|
|
|
*
|
|
|
|
|
*/
|
2010-03-27 15:25:51 +01:00
|
|
|
|
void x_con_kill(Con *con) {
|
|
|
|
|
con_state *state;
|
|
|
|
|
|
2016-09-14 09:13:17 +02:00
|
|
|
|
if (con->colormap != XCB_NONE) {
|
|
|
|
|
xcb_free_colormap(conn, con->colormap);
|
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_surface_free(conn, &(con->frame));
|
|
|
|
|
draw_util_surface_free(conn, &(con->frame_buffer));
|
|
|
|
|
xcb_destroy_window(conn, con->frame.id);
|
|
|
|
|
xcb_free_pixmap(conn, con->frame_buffer.id);
|
|
|
|
|
state = state_for_frame(con->frame.id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
CIRCLEQ_REMOVE(&state_head, state, state);
|
|
|
|
|
CIRCLEQ_REMOVE(&old_state_head, state, old_state);
|
2014-04-08 20:27:40 +02:00
|
|
|
|
TAILQ_REMOVE(&initial_mapping_head, state, initial_mapping_order);
|
2011-01-04 22:39:24 +01:00
|
|
|
|
FREE(state->name);
|
|
|
|
|
free(state);
|
2010-12-11 17:03:53 +01:00
|
|
|
|
|
|
|
|
|
/* Invalidate focused_id to correctly focus new windows with the same ID */
|
2014-02-22 11:52:01 +01:00
|
|
|
|
focused_id = last_focused = XCB_NONE;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Returns true if the client supports the given protocol atom (like WM_DELETE_WINDOW)
|
|
|
|
|
*
|
|
|
|
|
*/
|
2011-03-18 17:07:56 +01:00
|
|
|
|
bool window_supports_protocol(xcb_window_t window, xcb_atom_t atom) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
xcb_get_property_cookie_t cookie;
|
2011-03-18 14:36:36 +01:00
|
|
|
|
xcb_icccm_get_wm_protocols_reply_t protocols;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
bool result = false;
|
|
|
|
|
|
2011-07-31 18:19:41 +02:00
|
|
|
|
cookie = xcb_icccm_get_wm_protocols(conn, window, A_WM_PROTOCOLS);
|
2011-03-18 14:36:36 +01:00
|
|
|
|
if (xcb_icccm_get_wm_protocols_reply(conn, cookie, &protocols, NULL) != 1)
|
2010-03-27 15:25:51 +01:00
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
/* Check if the client’s protocols have the requested atom set */
|
|
|
|
|
for (uint32_t i = 0; i < protocols.atoms_len; i++)
|
|
|
|
|
if (protocols.atoms[i] == atom)
|
|
|
|
|
result = true;
|
|
|
|
|
|
2011-03-18 14:36:36 +01:00
|
|
|
|
xcb_icccm_get_wm_protocols_reply_wipe(&protocols);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
|
|
|
|
return result;
|
|
|
|
|
}
|
|
|
|
|
|
2010-07-13 11:35:05 +02:00
|
|
|
|
/*
|
|
|
|
|
* Kills the given X11 window using WM_DELETE_WINDOW (if supported).
|
|
|
|
|
*
|
|
|
|
|
*/
|
2011-05-13 20:41:03 +02:00
|
|
|
|
void x_window_kill(xcb_window_t window, kill_window_t kill_window) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/* if this window does not support WM_DELETE_WINDOW, we kill it the hard way */
|
2011-03-18 14:36:36 +01:00
|
|
|
|
if (!window_supports_protocol(window, A_WM_DELETE_WINDOW)) {
|
2011-05-13 20:41:03 +02:00
|
|
|
|
if (kill_window == KILL_WINDOW) {
|
|
|
|
|
LOG("Killing specific window 0x%08x\n", window);
|
|
|
|
|
xcb_destroy_window(conn, window);
|
|
|
|
|
} else {
|
|
|
|
|
LOG("Killing the X11 client which owns window 0x%08x\n", window);
|
|
|
|
|
xcb_kill_client(conn, window);
|
|
|
|
|
}
|
2010-03-27 15:25:51 +01:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-07-31 19:33:56 +02:00
|
|
|
|
/* Every X11 event is 32 bytes long. Therefore, XCB will copy 32 bytes.
|
|
|
|
|
* In order to properly initialize these bytes, we allocate 32 bytes even
|
|
|
|
|
* though we only need less for an xcb_configure_notify_event_t */
|
2015-08-03 11:50:13 +02:00
|
|
|
|
void *event = scalloc(32, 1);
|
2011-07-31 19:33:56 +02:00
|
|
|
|
xcb_client_message_event_t *ev = event;
|
|
|
|
|
|
|
|
|
|
ev->response_type = XCB_CLIENT_MESSAGE;
|
|
|
|
|
ev->window = window;
|
|
|
|
|
ev->type = A_WM_PROTOCOLS;
|
|
|
|
|
ev->format = 32;
|
|
|
|
|
ev->data.data32[0] = A_WM_DELETE_WINDOW;
|
|
|
|
|
ev->data.data32[1] = XCB_CURRENT_TIME;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
|
|
|
|
LOG("Sending WM_DELETE to the client\n");
|
2014-06-15 19:07:02 +02:00
|
|
|
|
xcb_send_event(conn, false, window, XCB_EVENT_MASK_NO_EVENT, (char *)ev);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
xcb_flush(conn);
|
2011-07-31 19:33:56 +02:00
|
|
|
|
free(event);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
2015-12-28 13:37:42 +01:00
|
|
|
|
static void x_draw_title_border(Con *con, struct deco_render_params *p) {
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
assert(con->parent != NULL);
|
|
|
|
|
|
|
|
|
|
Rect *dr = &(con->deco_rect);
|
|
|
|
|
adjacent_t borders_to_hide = con_adjacent_borders(con) & config.hide_edge_borders;
|
|
|
|
|
int deco_diff_l = borders_to_hide & ADJ_LEFT_SCREEN_EDGE ? 0 : con->current_border_width;
|
|
|
|
|
int deco_diff_r = borders_to_hide & ADJ_RIGHT_SCREEN_EDGE ? 0 : con->current_border_width;
|
|
|
|
|
if (con->parent->layout == L_TABBED ||
|
|
|
|
|
(con->parent->layout == L_STACKED && TAILQ_NEXT(con, nodes) != NULL)) {
|
|
|
|
|
deco_diff_l = 0;
|
|
|
|
|
deco_diff_r = 0;
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->parent->frame_buffer), p->color->border,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
dr->x, dr->y, dr->width, 1);
|
|
|
|
|
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->parent->frame_buffer), p->color->border,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
dr->x + deco_diff_l, dr->y + dr->height - 1, dr->width - (deco_diff_l + deco_diff_r), 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void x_draw_decoration_after_title(Con *con, struct deco_render_params *p) {
|
|
|
|
|
assert(con->parent != NULL);
|
|
|
|
|
|
|
|
|
|
Rect *dr = &(con->deco_rect);
|
|
|
|
|
|
|
|
|
|
/* Redraw the right border to cut off any text that went past it.
|
|
|
|
|
* This is necessary when the text was drawn using XCB since cutting text off
|
|
|
|
|
* automatically does not work there. For pango rendering, this isn't necessary. */
|
2016-04-13 19:48:53 +02:00
|
|
|
|
if (!font_is_pango()) {
|
2016-04-13 19:51:26 +02:00
|
|
|
|
/* We actually only redraw the far right two pixels as that is the
|
|
|
|
|
* distance we keep from the edge (not the entire border width).
|
|
|
|
|
* Redrawing the entire border would cause text to be cut off. */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->parent->frame_buffer), p->color->background,
|
2016-04-13 19:51:26 +02:00
|
|
|
|
dr->x + dr->width - 2 * logical_px(1),
|
|
|
|
|
dr->y,
|
|
|
|
|
2 * logical_px(1),
|
|
|
|
|
dr->height);
|
2016-04-13 19:48:53 +02:00
|
|
|
|
}
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
|
|
|
|
|
/* Draw a 1px separator line before and after every tab, so that tabs can
|
|
|
|
|
* be easily distinguished. */
|
|
|
|
|
if (con->parent->layout == L_TABBED) {
|
|
|
|
|
/* Left side */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->parent->frame_buffer), p->color->border,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
dr->x, dr->y, 1, dr->height);
|
|
|
|
|
|
|
|
|
|
/* Right side */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->parent->frame_buffer), p->color->border,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
dr->x + dr->width - 1, dr->y, 1, dr->height);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Redraw the border. */
|
2015-12-28 13:37:42 +01:00
|
|
|
|
x_draw_title_border(con, p);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
}
|
|
|
|
|
|
2010-07-13 11:35:05 +02:00
|
|
|
|
/*
|
|
|
|
|
* Draws the decoration of the given container onto its parent.
|
|
|
|
|
*
|
|
|
|
|
*/
|
2010-03-27 15:25:51 +01:00
|
|
|
|
void x_draw_decoration(Con *con) {
|
2011-05-29 13:03:36 +02:00
|
|
|
|
Con *parent = con->parent;
|
2011-08-25 00:23:33 +02:00
|
|
|
|
bool leaf = con_is_leaf(con);
|
2012-08-05 21:41:36 +02:00
|
|
|
|
|
2010-11-26 19:24:14 +01:00
|
|
|
|
/* This code needs to run for:
|
2010-11-13 22:39:59 +01:00
|
|
|
|
* • leaf containers
|
2011-02-02 17:56:29 +01:00
|
|
|
|
* • non-leaf containers which are in a stacked/tabbed container
|
2010-11-26 19:24:14 +01:00
|
|
|
|
*
|
|
|
|
|
* It does not need to run for:
|
2012-08-06 03:11:11 +02:00
|
|
|
|
* • direct children of outputs or dockareas
|
2010-11-26 19:24:14 +01:00
|
|
|
|
* • floating containers (they don’t have a decoration)
|
2010-11-13 22:39:59 +01:00
|
|
|
|
*/
|
2011-08-25 00:23:33 +02:00
|
|
|
|
if ((!leaf &&
|
2011-03-20 14:07:16 +01:00
|
|
|
|
parent->layout != L_STACKED &&
|
|
|
|
|
parent->layout != L_TABBED) ||
|
2012-08-05 21:41:36 +02:00
|
|
|
|
parent->type == CT_OUTPUT ||
|
2012-08-06 03:11:11 +02:00
|
|
|
|
parent->type == CT_DOCKAREA ||
|
2010-11-26 19:24:14 +01:00
|
|
|
|
con->type == CT_FLOATING_CON)
|
2010-11-13 18:15:15 +01:00
|
|
|
|
return;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-03-20 14:07:16 +01:00
|
|
|
|
/* Skip containers whose height is 0 (for example empty dockareas) */
|
2011-10-23 01:15:13 +02:00
|
|
|
|
if (con->rect.height == 0)
|
2011-03-20 14:07:16 +01:00
|
|
|
|
return;
|
|
|
|
|
|
2011-07-10 22:57:52 +02:00
|
|
|
|
/* Skip containers whose pixmap has not yet been created (can happen when
|
|
|
|
|
* decoration rendering happens recursively for a window for which
|
|
|
|
|
* x_push_node() was not yet called) */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (leaf && con->frame_buffer.id == XCB_NONE)
|
2011-07-10 22:57:52 +02:00
|
|
|
|
return;
|
|
|
|
|
|
2011-03-20 14:07:16 +01:00
|
|
|
|
/* 1: build deco_params and compare with cache */
|
2015-08-03 11:50:13 +02:00
|
|
|
|
struct deco_render_params *p = scalloc(1, sizeof(struct deco_render_params));
|
2011-03-20 14:07:16 +01:00
|
|
|
|
|
|
|
|
|
/* find out which colors to use */
|
2010-11-13 18:15:15 +01:00
|
|
|
|
if (con->urgent)
|
2011-03-20 14:07:16 +01:00
|
|
|
|
p->color = &config.client.urgent;
|
2011-08-26 03:17:41 +02:00
|
|
|
|
else if (con == focused || con_inside_focused(con))
|
2011-03-20 14:07:16 +01:00
|
|
|
|
p->color = &config.client.focused;
|
|
|
|
|
else if (con == TAILQ_FIRST(&(parent->focus_head)))
|
|
|
|
|
p->color = &config.client.focused_inactive;
|
2010-11-13 18:15:15 +01:00
|
|
|
|
else
|
2011-03-20 14:07:16 +01:00
|
|
|
|
p->color = &config.client.unfocused;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-03-20 14:07:16 +01:00
|
|
|
|
p->border_style = con_border_style(con);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-03-18 20:47:59 +01:00
|
|
|
|
Rect *r = &(con->rect);
|
|
|
|
|
Rect *w = &(con->window_rect);
|
2015-03-01 17:16:03 +01:00
|
|
|
|
p->con_rect = (struct width_height){r->width, r->height};
|
|
|
|
|
p->con_window_rect = (struct width_height){w->width, w->height};
|
2011-03-20 18:07:07 +01:00
|
|
|
|
p->con_deco_rect = con->deco_rect;
|
2011-03-20 14:07:16 +01:00
|
|
|
|
p->background = config.client.background;
|
|
|
|
|
p->con_is_leaf = con_is_leaf(con);
|
2013-04-29 10:14:11 +02:00
|
|
|
|
p->parent_layout = con->parent->layout;
|
2011-03-20 14:07:16 +01:00
|
|
|
|
|
|
|
|
|
if (con->deco_render_params != NULL &&
|
|
|
|
|
(con->window == NULL || !con->window->name_x_changed) &&
|
2011-05-29 13:03:36 +02:00
|
|
|
|
!parent->pixmap_recreated &&
|
|
|
|
|
!con->pixmap_recreated &&
|
2015-03-29 00:13:44 +01:00
|
|
|
|
!con->mark_changed &&
|
2011-03-20 14:07:16 +01:00
|
|
|
|
memcmp(p, con->deco_render_params, sizeof(struct deco_render_params)) == 0) {
|
|
|
|
|
free(p);
|
2011-07-10 16:22:09 +02:00
|
|
|
|
goto copy_pixmaps;
|
2011-03-20 14:07:16 +01:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-20 18:17:18 +01:00
|
|
|
|
Con *next = con;
|
|
|
|
|
while ((next = TAILQ_NEXT(next, nodes))) {
|
|
|
|
|
FREE(next->deco_render_params);
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-20 14:07:16 +01:00
|
|
|
|
FREE(con->deco_render_params);
|
|
|
|
|
con->deco_render_params = p;
|
|
|
|
|
|
|
|
|
|
if (con->window != NULL && con->window->name_x_changed)
|
|
|
|
|
con->window->name_x_changed = false;
|
|
|
|
|
|
2011-05-29 13:03:36 +02:00
|
|
|
|
parent->pixmap_recreated = false;
|
|
|
|
|
con->pixmap_recreated = false;
|
2015-03-29 00:13:44 +01:00
|
|
|
|
con->mark_changed = false;
|
2011-03-18 20:47:59 +01:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
/* 2: draw the client.background, but only for the parts around the window_rect */
|
2011-05-11 22:01:09 +02:00
|
|
|
|
if (con->window != NULL) {
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
/* top area */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), config.client.background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
0, 0, r->width, w->y);
|
|
|
|
|
/* bottom area */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), config.client.background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
0, w->y + w->height, r->width, r->height - (w->y + w->height));
|
|
|
|
|
/* left area */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), config.client.background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
0, 0, w->x, r->height);
|
|
|
|
|
/* right area */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), config.client.background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
w->x + w->width, 0, r->width - (w->x + w->width), r->height);
|
2011-05-11 22:01:09 +02:00
|
|
|
|
}
|
2011-03-18 20:47:59 +01:00
|
|
|
|
|
|
|
|
|
/* 3: draw a rectangle in border color around the client */
|
2011-03-20 14:07:16 +01:00
|
|
|
|
if (p->border_style != BS_NONE && p->con_is_leaf) {
|
2012-08-05 21:41:36 +02:00
|
|
|
|
/* We might hide some borders adjacent to the screen-edge */
|
|
|
|
|
adjacent_t borders_to_hide = ADJ_NONE;
|
|
|
|
|
borders_to_hide = con_adjacent_borders(con) & config.hide_edge_borders;
|
|
|
|
|
|
2010-11-13 22:39:59 +01:00
|
|
|
|
Rect br = con_border_style_rect(con);
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
/* These rectangles represent the border around the child window
|
2010-11-14 21:17:27 +01:00
|
|
|
|
* (left, bottom and right part). We don’t just fill the whole
|
|
|
|
|
* rectangle because some childs are not freely resizable and we want
|
|
|
|
|
* their background color to "shine through". */
|
2012-08-05 21:41:36 +02:00
|
|
|
|
if (!(borders_to_hide & ADJ_LEFT_SCREEN_EDGE)) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), p->color->child_border, 0, 0, br.x, r->height);
|
2012-07-22 11:57:07 +02:00
|
|
|
|
}
|
2012-08-05 21:41:36 +02:00
|
|
|
|
if (!(borders_to_hide & ADJ_RIGHT_SCREEN_EDGE)) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer),
|
2016-01-09 22:47:33 +01:00
|
|
|
|
p->color->child_border, r->width + (br.width + br.x), 0,
|
2015-12-28 13:37:42 +01:00
|
|
|
|
-(br.width + br.x), r->height);
|
2012-07-22 11:57:07 +02:00
|
|
|
|
}
|
2012-08-05 21:41:36 +02:00
|
|
|
|
if (!(borders_to_hide & ADJ_LOWER_SCREEN_EDGE)) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer),
|
2016-01-09 22:47:33 +01:00
|
|
|
|
p->color->child_border, br.x, r->height + (br.height + br.y),
|
2015-12-28 13:37:42 +01:00
|
|
|
|
r->width + br.width, -(br.height + br.y));
|
2012-08-05 21:41:36 +02:00
|
|
|
|
}
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
/* pixel border needs an additional line at the top */
|
2012-09-24 01:14:00 +02:00
|
|
|
|
if (p->border_style == BS_PIXEL && !(borders_to_hide & ADJ_UPPER_SCREEN_EDGE)) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer),
|
2016-01-09 22:47:33 +01:00
|
|
|
|
p->color->child_border, br.x, 0, r->width + br.width, br.y);
|
2010-11-13 22:39:59 +01:00
|
|
|
|
}
|
2012-01-22 12:22:15 +01:00
|
|
|
|
|
|
|
|
|
/* Highlight the side of the border at which the next window will be
|
|
|
|
|
* opened if we are rendering a single window within a split container
|
|
|
|
|
* (which is undistinguishable from a single window outside a split
|
|
|
|
|
* container otherwise. */
|
|
|
|
|
if (TAILQ_NEXT(con, nodes) == NULL &&
|
|
|
|
|
TAILQ_PREV(con, nodes_head, nodes) == NULL &&
|
|
|
|
|
con->parent->type != CT_FLOATING_CON) {
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (p->parent_layout == L_SPLITH) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), p->color->indicator,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
r->width + (br.width + br.x), br.y, -(br.width + br.x), r->height + br.height);
|
|
|
|
|
} else if (p->parent_layout == L_SPLITV) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(con->frame_buffer), p->color->indicator,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
br.x, r->height + (br.height + br.y), r->width + br.width, -(br.height + br.y));
|
|
|
|
|
}
|
2012-01-22 12:22:15 +01:00
|
|
|
|
}
|
2010-11-13 18:15:15 +01:00
|
|
|
|
}
|
2010-11-13 22:39:59 +01:00
|
|
|
|
|
2012-01-21 11:59:23 +01:00
|
|
|
|
/* if this is a borderless/1pixel window, we don’t need to render the
|
2010-11-13 22:39:59 +01:00
|
|
|
|
* decoration. */
|
2011-10-23 01:15:13 +02:00
|
|
|
|
if (p->border_style != BS_NORMAL)
|
2011-07-10 16:22:09 +02:00
|
|
|
|
goto copy_pixmaps;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2015-11-16 21:28:33 +01:00
|
|
|
|
/* If the parent hasn't been set up yet, skip the decoration rendering
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
* for now. */
|
|
|
|
|
if (parent->frame_buffer.id == XCB_NONE)
|
|
|
|
|
goto copy_pixmaps;
|
|
|
|
|
|
2015-11-17 12:50:06 +01:00
|
|
|
|
/* For the first child, we clear the parent pixmap to ensure there's no
|
|
|
|
|
* garbage left on there. This is important to avoid tearing when using
|
|
|
|
|
* transparency. */
|
|
|
|
|
if (con == TAILQ_FIRST(&(con->parent->nodes_head))) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_clear_surface(&(con->parent->frame_buffer), COLOR_TRANSPARENT);
|
2015-11-17 12:50:06 +01:00
|
|
|
|
FREE(con->parent->deco_render_params);
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-18 20:47:59 +01:00
|
|
|
|
/* 4: paint the bar */
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_rectangle(&(parent->frame_buffer), p->color->background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
con->deco_rect.x, con->deco_rect.y, con->deco_rect.width, con->deco_rect.height);
|
2010-04-13 17:46:54 +02:00
|
|
|
|
|
2012-12-20 18:32:11 +01:00
|
|
|
|
/* 5: draw two unconnected horizontal lines in border color */
|
2015-12-28 13:37:42 +01:00
|
|
|
|
x_draw_title_border(con, p);
|
2010-11-13 18:15:15 +01:00
|
|
|
|
|
2011-03-18 20:47:59 +01:00
|
|
|
|
/* 6: draw the title */
|
2011-11-14 00:23:25 +01:00
|
|
|
|
int text_offset_y = (con->deco_rect.height - config.font.height) / 2;
|
2010-11-13 22:39:59 +01:00
|
|
|
|
|
|
|
|
|
struct Window *win = con->window;
|
2012-09-23 06:09:34 +02:00
|
|
|
|
if (win == NULL) {
|
2015-12-29 18:01:51 +01:00
|
|
|
|
i3String *title;
|
|
|
|
|
if (con->title_format == NULL) {
|
|
|
|
|
char *_title;
|
|
|
|
|
char *tree = con_get_tree_representation(con);
|
|
|
|
|
sasprintf(&_title, "i3: %s", tree);
|
|
|
|
|
free(tree);
|
|
|
|
|
|
|
|
|
|
title = i3string_from_utf8(_title);
|
|
|
|
|
FREE(_title);
|
|
|
|
|
} else {
|
|
|
|
|
title = con_parse_title_format(con);
|
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_text(title, &(parent->frame_buffer),
|
2015-11-16 23:03:39 +01:00
|
|
|
|
p->color->text, p->color->background,
|
2016-04-13 19:55:59 +02:00
|
|
|
|
con->deco_rect.x + logical_px(2),
|
|
|
|
|
con->deco_rect.y + text_offset_y,
|
|
|
|
|
con->deco_rect.width - 2 * logical_px(2));
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
I3STRING_FREE(title);
|
2012-09-09 06:37:51 +02:00
|
|
|
|
|
2012-12-19 21:12:38 +01:00
|
|
|
|
goto after_title;
|
2010-11-13 22:39:59 +01:00
|
|
|
|
}
|
|
|
|
|
|
2015-03-29 00:09:10 +01:00
|
|
|
|
int mark_width = 0;
|
2015-10-19 18:10:20 +02:00
|
|
|
|
if (config.show_marks && !TAILQ_EMPTY(&(con->marks_head))) {
|
|
|
|
|
char *formatted_mark = sstrdup("");
|
|
|
|
|
bool had_visible_mark = false;
|
|
|
|
|
|
|
|
|
|
mark_t *mark;
|
|
|
|
|
TAILQ_FOREACH(mark, &(con->marks_head), marks) {
|
|
|
|
|
if (mark->name[0] == '_')
|
|
|
|
|
continue;
|
|
|
|
|
had_visible_mark = true;
|
|
|
|
|
|
|
|
|
|
char *buf;
|
|
|
|
|
sasprintf(&buf, "%s[%s]", formatted_mark, mark->name);
|
|
|
|
|
free(formatted_mark);
|
|
|
|
|
formatted_mark = buf;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (had_visible_mark) {
|
|
|
|
|
i3String *mark = i3string_from_utf8(formatted_mark);
|
|
|
|
|
mark_width = predict_text_width(mark);
|
2015-03-29 00:09:10 +01:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_text(mark, &(parent->frame_buffer),
|
2015-11-16 23:03:39 +01:00
|
|
|
|
p->color->text, p->color->background,
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
con->deco_rect.x + con->deco_rect.width - mark_width - logical_px(2),
|
|
|
|
|
con->deco_rect.y + text_offset_y, mark_width);
|
2015-03-29 00:09:10 +01:00
|
|
|
|
|
2015-10-19 18:10:20 +02:00
|
|
|
|
I3STRING_FREE(mark);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FREE(formatted_mark);
|
2015-03-29 00:09:10 +01:00
|
|
|
|
}
|
|
|
|
|
|
2015-12-29 18:01:51 +01:00
|
|
|
|
i3String *title = con->title_format == NULL ? win->name : con_parse_title_format(con);
|
2017-01-16 23:00:01 +01:00
|
|
|
|
if (title == NULL) {
|
|
|
|
|
goto copy_pixmaps;
|
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_text(title, &(parent->frame_buffer),
|
2015-11-16 23:03:39 +01:00
|
|
|
|
p->color->text, p->color->background,
|
2016-05-01 18:59:50 +02:00
|
|
|
|
con->deco_rect.x + logical_px(2),
|
2016-04-13 19:55:59 +02:00
|
|
|
|
con->deco_rect.y + text_offset_y,
|
2016-05-01 18:59:50 +02:00
|
|
|
|
con->deco_rect.width - mark_width - 2 * logical_px(2));
|
2017-01-16 23:00:01 +01:00
|
|
|
|
|
|
|
|
|
if (con->title_format != NULL) {
|
2015-06-10 19:01:05 +02:00
|
|
|
|
I3STRING_FREE(title);
|
2017-01-16 23:00:01 +01:00
|
|
|
|
}
|
2011-03-20 14:07:16 +01:00
|
|
|
|
|
2012-12-19 21:12:38 +01:00
|
|
|
|
after_title:
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
x_draw_decoration_after_title(con, p);
|
2011-07-10 16:22:09 +02:00
|
|
|
|
copy_pixmaps:
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_copy_surface(&(con->frame_buffer), &(con->frame), 0, 0, 0, 0, con->rect.width, con->rect.height);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-29 11:31:22 +02:00
|
|
|
|
/*
|
|
|
|
|
* Recursively calls x_draw_decoration. This cannot be done in x_push_node
|
|
|
|
|
* because x_push_node uses focus order to recurse (see the comment above)
|
|
|
|
|
* while drawing the decoration needs to happen in the actual order.
|
|
|
|
|
*
|
|
|
|
|
*/
|
2011-07-10 22:06:16 +02:00
|
|
|
|
void x_deco_recurse(Con *con) {
|
2011-05-29 11:31:22 +02:00
|
|
|
|
Con *current;
|
2011-07-10 20:01:29 +02:00
|
|
|
|
bool leaf = TAILQ_EMPTY(&(con->nodes_head)) &&
|
|
|
|
|
TAILQ_EMPTY(&(con->floating_head));
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
con_state *state = state_for_frame(con->frame.id);
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
2011-07-10 20:01:29 +02:00
|
|
|
|
if (!leaf) {
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->nodes_head), nodes)
|
|
|
|
|
x_deco_recurse(current);
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->floating_head), floating_windows)
|
|
|
|
|
x_deco_recurse(current);
|
2011-07-10 20:01:29 +02:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (state->mapped) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_copy_surface(&(con->frame_buffer), &(con->frame), 0, 0, 0, 0, con->rect.width, con->rect.height);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
}
|
2011-07-10 20:01:29 +02:00
|
|
|
|
}
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
|
|
|
|
if ((con->type != CT_ROOT && con->type != CT_OUTPUT) &&
|
2011-08-25 00:23:33 +02:00
|
|
|
|
(!leaf || con->mapped))
|
2011-05-29 11:31:22 +02:00
|
|
|
|
x_draw_decoration(con);
|
|
|
|
|
}
|
|
|
|
|
|
2015-04-16 19:43:23 +02:00
|
|
|
|
/*
|
|
|
|
|
* Sets or removes the _NET_WM_STATE_HIDDEN property on con if necessary.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
static void set_hidden_state(Con *con) {
|
|
|
|
|
if (con->window == NULL) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
con_state *state = state_for_frame(con->frame.id);
|
2015-04-16 19:43:23 +02:00
|
|
|
|
bool should_be_hidden = con_is_hidden(con);
|
|
|
|
|
if (should_be_hidden == state->is_hidden)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (should_be_hidden) {
|
|
|
|
|
DLOG("setting _NET_WM_STATE_HIDDEN for con = %p\n", con);
|
2015-09-14 13:34:15 +02:00
|
|
|
|
xcb_add_property_atom(conn, con->window->id, A__NET_WM_STATE, A__NET_WM_STATE_HIDDEN);
|
2015-04-16 19:43:23 +02:00
|
|
|
|
} else {
|
|
|
|
|
DLOG("removing _NET_WM_STATE_HIDDEN for con = %p\n", con);
|
2015-09-14 13:34:15 +02:00
|
|
|
|
xcb_remove_property_atom(conn, con->window->id, A__NET_WM_STATE, A__NET_WM_STATE_HIDDEN);
|
2015-04-16 19:43:23 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
state->is_hidden = should_be_hidden;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/*
|
|
|
|
|
* This function pushes the properties of each node of the layout tree to
|
|
|
|
|
* X11 if they have changed (like the map state, position of the window, …).
|
|
|
|
|
* It recursively traverses all children of the given node.
|
|
|
|
|
*
|
|
|
|
|
*/
|
2011-05-01 18:48:30 +02:00
|
|
|
|
void x_push_node(Con *con) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
Con *current;
|
|
|
|
|
con_state *state;
|
2010-11-14 18:52:40 +01:00
|
|
|
|
Rect rect = con->rect;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Pushing changes for node %p / %s\n", con, con->name);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
state = state_for_frame(con->frame.id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2010-11-14 16:41:46 +01:00
|
|
|
|
if (state->name != NULL) {
|
2010-11-14 22:35:44 +01:00
|
|
|
|
DLOG("pushing name %s for con %p\n", state->name, con);
|
2010-11-14 16:41:46 +01:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, con->frame.id,
|
2011-08-17 01:41:19 +02:00
|
|
|
|
XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 8, strlen(state->name), state->name);
|
2010-11-14 16:41:46 +01:00
|
|
|
|
FREE(state->name);
|
|
|
|
|
}
|
|
|
|
|
|
2010-11-14 18:52:40 +01:00
|
|
|
|
if (con->window == NULL) {
|
|
|
|
|
/* Calculate the height of all window decorations which will be drawn on to
|
|
|
|
|
* this frame. */
|
|
|
|
|
uint32_t max_y = 0, max_height = 0;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->nodes_head), nodes) {
|
2010-11-14 18:52:40 +01:00
|
|
|
|
Rect *dr = &(current->deco_rect);
|
|
|
|
|
if (dr->y >= max_y && dr->height >= max_height) {
|
|
|
|
|
max_y = dr->y;
|
|
|
|
|
max_height = dr->height;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
rect.height = max_y + max_height;
|
2011-10-23 01:15:13 +02:00
|
|
|
|
if (rect.height == 0)
|
2010-11-14 18:52:40 +01:00
|
|
|
|
con->mapped = false;
|
|
|
|
|
}
|
|
|
|
|
|
2010-09-01 18:11:01 +02:00
|
|
|
|
/* reparent the child window (when the window was moved due to a sticky
|
|
|
|
|
* container) */
|
|
|
|
|
if (state->need_reparent && con->window != NULL) {
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("Reparenting child window\n");
|
2010-09-01 18:11:01 +02:00
|
|
|
|
|
|
|
|
|
/* Temporarily set the event masks to XCB_NONE so that we won’t get
|
|
|
|
|
* UnmapNotify events (otherwise the handler would close the container).
|
|
|
|
|
* These events are generated automatically when reparenting. */
|
2014-06-15 19:07:02 +02:00
|
|
|
|
uint32_t values[] = {XCB_NONE};
|
2010-09-01 18:11:01 +02:00
|
|
|
|
xcb_change_window_attributes(conn, state->old_frame, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
xcb_change_window_attributes(conn, con->window->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_reparent_window(conn, con->window->id, con->frame.id, 0, 0);
|
2010-09-01 18:11:01 +02:00
|
|
|
|
|
|
|
|
|
values[0] = FRAME_EVENT_MASK;
|
|
|
|
|
xcb_change_window_attributes(conn, state->old_frame, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
values[0] = CHILD_EVENT_MASK;
|
|
|
|
|
xcb_change_window_attributes(conn, con->window->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
|
|
|
|
|
state->old_frame = XCB_NONE;
|
|
|
|
|
state->need_reparent = false;
|
2010-11-20 19:11:43 +01:00
|
|
|
|
|
|
|
|
|
con->ignore_unmap++;
|
|
|
|
|
DLOG("ignore_unmap for reparenting of con %p (win 0x%08x) is now %d\n",
|
2014-06-15 19:07:02 +02:00
|
|
|
|
con, con->window->id, con->ignore_unmap);
|
2010-09-01 18:11:01 +02:00
|
|
|
|
}
|
|
|
|
|
|
2014-06-24 23:27:01 +02:00
|
|
|
|
/* The pixmap of a borderless leaf container will not be used except
|
|
|
|
|
* for the titlebar in a stack or tabs (issue #1013). */
|
|
|
|
|
bool is_pixmap_needed = (con->border_style != BS_NONE ||
|
|
|
|
|
!con_is_leaf(con) ||
|
|
|
|
|
con->parent->layout == L_STACKED ||
|
|
|
|
|
con->parent->layout == L_TABBED);
|
|
|
|
|
|
2015-11-16 23:40:41 +01:00
|
|
|
|
/* The root con and output cons will never require a pixmap. In particular for the
|
|
|
|
|
* __i3 output, this will likely not work anyway because it might be ridiculously
|
|
|
|
|
* large, causing an XCB_ALLOC error. */
|
|
|
|
|
if (con->type == CT_ROOT || con->type == CT_OUTPUT)
|
|
|
|
|
is_pixmap_needed = false;
|
|
|
|
|
|
2010-11-27 16:44:45 +01:00
|
|
|
|
bool fake_notify = false;
|
2014-06-24 23:27:01 +02:00
|
|
|
|
/* Set new position if rect changed (and if height > 0) or if the pixmap
|
|
|
|
|
* needs to be recreated */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((is_pixmap_needed && con->frame_buffer.id == XCB_NONE) || (memcmp(&(state->rect), &rect, sizeof(Rect)) != 0 &&
|
|
|
|
|
rect.height > 0)) {
|
2011-05-29 11:31:22 +02:00
|
|
|
|
/* We first create the new pixmap, then render to it, set it as the
|
|
|
|
|
* background and only afterwards change the window size. This reduces
|
|
|
|
|
* flickering. */
|
2011-03-20 14:07:16 +01:00
|
|
|
|
|
|
|
|
|
/* As the pixmap only depends on the size and not on the position, it
|
2011-04-01 21:54:45 +02:00
|
|
|
|
* is enough to check if width/height have changed. Also, we don’t
|
|
|
|
|
* create a pixmap at all when the window is actually not visible
|
2014-02-04 19:36:20 +01:00
|
|
|
|
* (height == 0) or when it is not needed. */
|
|
|
|
|
bool has_rect_changed = (state->rect.width != rect.width || state->rect.height != rect.height);
|
|
|
|
|
|
|
|
|
|
/* Check if the container has an unneeded pixmap left over from
|
|
|
|
|
* previously having a border or titlebar. */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (!is_pixmap_needed && con->frame_buffer.id != XCB_NONE) {
|
|
|
|
|
draw_util_surface_free(conn, &(con->frame_buffer));
|
|
|
|
|
xcb_free_pixmap(conn, con->frame_buffer.id);
|
|
|
|
|
con->frame_buffer.id = XCB_NONE;
|
2014-02-04 19:36:20 +01:00
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (is_pixmap_needed && (has_rect_changed || con->frame_buffer.id == XCB_NONE)) {
|
|
|
|
|
if (con->frame_buffer.id == XCB_NONE) {
|
|
|
|
|
con->frame_buffer.id = xcb_generate_id(conn);
|
2011-03-20 14:07:16 +01:00
|
|
|
|
} else {
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_surface_free(conn, &(con->frame_buffer));
|
|
|
|
|
xcb_free_pixmap(conn, con->frame_buffer.id);
|
2011-03-20 14:07:16 +01:00
|
|
|
|
}
|
2012-03-01 06:53:06 +01:00
|
|
|
|
|
|
|
|
|
uint16_t win_depth = root_depth;
|
|
|
|
|
if (con->window)
|
|
|
|
|
win_depth = con->window->depth;
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
/* Ensure we have valid dimensions for our surface. */
|
|
|
|
|
// TODO This is probably a bug in the condition above as we should never enter this path
|
|
|
|
|
// for height == 0. Also, we should probably handle width == 0 the same way.
|
2015-12-03 18:57:02 +01:00
|
|
|
|
int width = MAX((int32_t)rect.width, 1);
|
|
|
|
|
int height = MAX((int32_t)rect.height, 1);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
|
2016-09-14 09:22:06 +02:00
|
|
|
|
xcb_create_pixmap(conn, win_depth, con->frame_buffer.id, con->frame.id, width, height);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_surface_init(conn, &(con->frame_buffer), con->frame_buffer.id,
|
|
|
|
|
get_visualtype_by_id(get_visualid_by_depth(win_depth)), width, height);
|
2012-03-01 06:53:06 +01:00
|
|
|
|
|
2011-07-10 22:27:31 +02:00
|
|
|
|
/* For the graphics context, we disable GraphicsExposure events.
|
|
|
|
|
* Those will be sent when a CopyArea request cannot be fulfilled
|
|
|
|
|
* properly due to parts of the source being unmapped or otherwise
|
|
|
|
|
* unavailable. Since we always copy from pixmaps to windows, this
|
|
|
|
|
* is not a concern for us. */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_change_gc(conn, con->frame_buffer.gc, XCB_GC_GRAPHICS_EXPOSURES, (uint32_t[]){0});
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
draw_util_surface_set_size(&(con->frame), width, height);
|
2011-05-29 12:20:09 +02:00
|
|
|
|
con->pixmap_recreated = true;
|
|
|
|
|
|
2011-07-10 21:54:34 +02:00
|
|
|
|
/* Don’t render the decoration for windows inside a stack which are
|
|
|
|
|
* not visible right now */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
// TODO Should this work the same way for L_TABBED?
|
2011-07-10 21:54:34 +02:00
|
|
|
|
if (!con->parent ||
|
|
|
|
|
con->parent->layout != L_STACKED ||
|
|
|
|
|
TAILQ_FIRST(&(con->parent->focus_head)) == con)
|
|
|
|
|
/* Render the decoration now to make the correct decoration visible
|
|
|
|
|
* from the very first moment. Later calls will be cached, so this
|
|
|
|
|
* doesn’t hurt performance. */
|
|
|
|
|
x_deco_recurse(con);
|
2011-03-20 14:07:16 +01:00
|
|
|
|
}
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
|
|
|
|
DLOG("setting rect (%d, %d, %d, %d)\n", rect.x, rect.y, rect.width, rect.height);
|
2011-07-10 20:08:40 +02:00
|
|
|
|
/* flush to ensure that the following commands are sent in a single
|
|
|
|
|
* buffer and will be processed directly afterwards (the contents of a
|
|
|
|
|
* window get lost when resizing it, therefore we want to provide it as
|
|
|
|
|
* fast as possible) */
|
|
|
|
|
xcb_flush(conn);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_set_window_rect(conn, con->frame.id, rect);
|
|
|
|
|
if (con->frame_buffer.id != XCB_NONE) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_copy_surface(&(con->frame_buffer), &(con->frame), 0, 0, 0, 0, con->rect.width, con->rect.height);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
}
|
2011-07-10 20:08:40 +02:00
|
|
|
|
xcb_flush(conn);
|
2011-05-29 11:31:22 +02:00
|
|
|
|
|
2010-11-27 16:44:45 +01:00
|
|
|
|
memcpy(&(state->rect), &rect, sizeof(Rect));
|
|
|
|
|
fake_notify = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* dito, but for child windows */
|
|
|
|
|
if (con->window != NULL &&
|
|
|
|
|
memcmp(&(state->window_rect), &(con->window_rect), sizeof(Rect)) != 0) {
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("setting window rect (%d, %d, %d, %d)\n",
|
2014-06-15 19:07:02 +02:00
|
|
|
|
con->window_rect.x, con->window_rect.y, con->window_rect.width, con->window_rect.height);
|
2010-11-27 16:44:45 +01:00
|
|
|
|
xcb_set_window_rect(conn, con->window->id, con->window_rect);
|
|
|
|
|
memcpy(&(state->window_rect), &(con->window_rect), sizeof(Rect));
|
|
|
|
|
fake_notify = true;
|
|
|
|
|
}
|
|
|
|
|
|
2010-11-27 17:45:23 +01:00
|
|
|
|
/* Map if map state changed, also ensure that the child window
|
2013-12-15 14:57:04 +01:00
|
|
|
|
* is changed if we are mapped and there is a new, unmapped child window.
|
|
|
|
|
* Unmaps are handled in x_push_node_unmaps(). */
|
|
|
|
|
if ((state->mapped != con->mapped || (con->window != NULL && !state->child_mapped)) &&
|
2010-11-27 17:45:23 +01:00
|
|
|
|
con->mapped) {
|
|
|
|
|
xcb_void_cookie_t cookie;
|
|
|
|
|
|
|
|
|
|
if (con->window != NULL) {
|
|
|
|
|
/* Set WM_STATE_NORMAL because GTK applications don’t want to
|
|
|
|
|
* drag & drop if we don’t. Also, xprop(1) needs it. */
|
2014-06-15 19:07:02 +02:00
|
|
|
|
long data[] = {XCB_ICCCM_WM_STATE_NORMAL, XCB_NONE};
|
2010-11-27 17:45:23 +01:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, con->window->id,
|
2011-03-18 14:36:36 +01:00
|
|
|
|
A_WM_STATE, A_WM_STATE, 32, 2, data);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
}
|
2010-11-14 13:53:47 +01:00
|
|
|
|
|
2011-07-04 13:41:02 +02:00
|
|
|
|
uint32_t values[1];
|
2010-11-28 22:08:34 +01:00
|
|
|
|
if (!state->child_mapped && con->window != NULL) {
|
2010-11-27 17:45:23 +01:00
|
|
|
|
cookie = xcb_map_window(conn, con->window->id);
|
2011-07-04 13:41:02 +02:00
|
|
|
|
|
|
|
|
|
/* We are interested in EnterNotifys as soon as the window is
|
|
|
|
|
* mapped */
|
|
|
|
|
values[0] = CHILD_EVENT_MASK;
|
|
|
|
|
xcb_change_window_attributes(conn, con->window->id, XCB_CW_EVENT_MASK, values);
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("mapping child window (serial %d)\n", cookie.sequence);
|
2010-11-28 22:08:34 +01:00
|
|
|
|
state->child_mapped = true;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
2010-11-27 17:45:23 +01:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
cookie = xcb_map_window(conn, con->frame.id);
|
2011-07-04 13:41:02 +02:00
|
|
|
|
|
|
|
|
|
values[0] = FRAME_EVENT_MASK;
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_change_window_attributes(conn, con->frame.id, XCB_CW_EVENT_MASK, values);
|
2011-07-04 13:41:02 +02:00
|
|
|
|
|
2011-07-10 20:15:22 +02:00
|
|
|
|
/* copy the pixmap contents to the frame window immediately after mapping */
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if (con->frame_buffer.id != XCB_NONE) {
|
2017-01-13 18:34:09 +01:00
|
|
|
|
draw_util_copy_surface(&(con->frame_buffer), &(con->frame), 0, 0, 0, 0, con->rect.width, con->rect.height);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
}
|
2011-07-10 20:15:22 +02:00
|
|
|
|
xcb_flush(conn);
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
DLOG("mapping container %08x (serial %d)\n", con->frame.id, cookie.sequence);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
state->mapped = con->mapped;
|
|
|
|
|
}
|
|
|
|
|
|
2011-07-04 13:41:02 +02:00
|
|
|
|
state->unmap_now = (state->mapped != con->mapped) && !con->mapped;
|
|
|
|
|
|
2010-05-31 23:00:36 +02:00
|
|
|
|
if (fake_notify) {
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("Sending fake configure notify\n");
|
2010-05-31 23:00:36 +02:00
|
|
|
|
fake_absolute_configure_notify(con);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
2015-04-16 19:43:23 +02:00
|
|
|
|
set_hidden_state(con);
|
|
|
|
|
|
2011-04-01 20:40:32 +02:00
|
|
|
|
/* Handle all children and floating windows of this node. We recurse
|
|
|
|
|
* in focus order to display the focused client in a stack first when
|
|
|
|
|
* switching workspaces (reduces flickering). */
|
2016-02-26 22:39:44 +01:00
|
|
|
|
TAILQ_FOREACH(current, &(con->focus_head), focused) {
|
|
|
|
|
x_push_node(current);
|
|
|
|
|
}
|
2011-05-01 18:48:30 +02:00
|
|
|
|
}
|
|
|
|
|
|
2010-11-27 17:45:23 +01:00
|
|
|
|
/*
|
|
|
|
|
* Same idea as in x_push_node(), but this function only unmaps windows. It is
|
|
|
|
|
* necessary to split this up to handle new fullscreen clients properly: The
|
|
|
|
|
* new window needs to be mapped and focus needs to be set *before* the
|
|
|
|
|
* underlying windows are unmapped. Otherwise, focus will revert to the
|
|
|
|
|
* PointerRoot and will then be set to the new window, generating unnecessary
|
|
|
|
|
* FocusIn/FocusOut events.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
static void x_push_node_unmaps(Con *con) {
|
|
|
|
|
Con *current;
|
|
|
|
|
con_state *state;
|
|
|
|
|
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Pushing changes (with unmaps) for node %p / %s\n", con, con->name);
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
state = state_for_frame(con->frame.id);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
|
|
|
|
|
/* map/unmap if map state changed, also ensure that the child window
|
|
|
|
|
* is changed if we are mapped *and* in initial state (meaning the
|
|
|
|
|
* container was empty before, but now got a child) */
|
2011-07-04 13:41:02 +02:00
|
|
|
|
if (state->unmap_now) {
|
2010-11-27 17:45:23 +01:00
|
|
|
|
xcb_void_cookie_t cookie;
|
|
|
|
|
if (con->window != NULL) {
|
|
|
|
|
/* Set WM_STATE_WITHDRAWN, it seems like Java apps need it */
|
2014-06-15 19:07:02 +02:00
|
|
|
|
long data[] = {XCB_ICCCM_WM_STATE_WITHDRAWN, XCB_NONE};
|
2010-11-27 17:45:23 +01:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, con->window->id,
|
2011-03-18 14:36:36 +01:00
|
|
|
|
A_WM_STATE, A_WM_STATE, 32, 2, data);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
}
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
cookie = xcb_unmap_window(conn, con->frame.id);
|
2012-09-29 00:02:41 +02:00
|
|
|
|
DLOG("unmapping container %p / %s (serial %d)\n", con, con->name, cookie.sequence);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
/* we need to increase ignore_unmap for this container (if it
|
|
|
|
|
* contains a window) and for every window "under" this one which
|
|
|
|
|
* contains a window */
|
|
|
|
|
if (con->window != NULL) {
|
|
|
|
|
con->ignore_unmap++;
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
DLOG("ignore_unmap for con %p (frame 0x%08x) now %d\n", con, con->frame.id, con->ignore_unmap);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
}
|
|
|
|
|
state->mapped = con->mapped;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* handle all children and floating windows of this node */
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->nodes_head), nodes)
|
|
|
|
|
x_push_node_unmaps(current);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->floating_head), floating_windows)
|
|
|
|
|
x_push_node_unmaps(current);
|
2010-11-27 17:45:23 +01:00
|
|
|
|
}
|
|
|
|
|
|
2014-02-22 11:52:01 +01:00
|
|
|
|
/*
|
|
|
|
|
* Returns true if the given container is currently attached to its parent.
|
|
|
|
|
*
|
|
|
|
|
* TODO: Remove once #1185 has been fixed
|
|
|
|
|
*/
|
|
|
|
|
static bool is_con_attached(Con *con) {
|
|
|
|
|
if (con->parent == NULL)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
Con *current;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(current, &(con->parent->nodes_head), nodes) {
|
2014-02-22 11:52:01 +01:00
|
|
|
|
if (current == con)
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/*
|
|
|
|
|
* Pushes all changes (state of each node, see x_push_node() and the window
|
|
|
|
|
* stack) to X11.
|
|
|
|
|
*
|
2011-01-21 21:49:56 +01:00
|
|
|
|
* NOTE: We need to push the stack first so that the windows have the correct
|
|
|
|
|
* stacking order. This is relevant for workspace switching where we map the
|
|
|
|
|
* windows because mapping may generate EnterNotify events. When they are
|
|
|
|
|
* generated in the wrong order, this will cause focus problems when switching
|
|
|
|
|
* workspaces.
|
|
|
|
|
*
|
2010-03-27 15:25:51 +01:00
|
|
|
|
*/
|
|
|
|
|
void x_push_changes(Con *con) {
|
|
|
|
|
con_state *state;
|
2011-09-17 21:53:24 +02:00
|
|
|
|
xcb_query_pointer_cookie_t pointercookie;
|
|
|
|
|
|
|
|
|
|
/* If we need to warp later, we request the pointer position as soon as possible */
|
|
|
|
|
if (warp_to) {
|
|
|
|
|
pointercookie = xcb_query_pointer(conn, root);
|
|
|
|
|
}
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-01-07 20:58:58 +01:00
|
|
|
|
DLOG("-- PUSHING WINDOW STACK --\n");
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Disabling EnterNotify\n");
|
Bugfix: don’t remove SubstructureRedirect event mask temporarily
This fixes race conditions, for example when i3bar gets reconfigured
after the available outputs change. In that specific case, i3bar sends a
ConfigureWindow request (see
https://github.com/i3/i3/blob/b5693d6fb33ad29337e4187a2db4a2618ea8fb4c/i3bar/src/xcb.c#L376)
which normally is turned into a ConfigureRequest that i3 largely
ignores, only the dock client’s height is considered (see
https://github.com/i3/i3/blob/b5693d6fb33ad29337e4187a2db4a2618ea8fb4c/src/handlers.c#L390).
Turning ConfigureWindow into ConfigureRequest is only done when the
SubstructureRedirect event mask is set, and because we temporarily
removed _all_ events from our mask, the ConfigureWindow request went
through unmodified.
This in turn lead to the i3bar client window (not its decoration frame)
being positioned at e.g. y=1304, whereas dock client windows should
always end up at x=0 y=0 within their decoration frame. The result of
the i3bar client window being out of the visible space was either a
black i3bar or graphics corruption.
This also fixes issue #1904, I think. I couldn’t reproduce issue #1904
specifically, but when i3bar is in the misconfigured state, it will
receive a VisibilityNotify event, telling i3bar that it is obscured.
This would explain why i3bar sent a SIGSTOP in issue #1904.
fixes #1904
2015-12-22 22:33:37 +01:00
|
|
|
|
/* We need to keep SubstructureRedirect around, otherwise clients can send
|
|
|
|
|
* ConfigureWindow requests and get them applied directly instead of having
|
|
|
|
|
* them become ConfigureRequests that i3 handles. */
|
|
|
|
|
uint32_t values[1] = {XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT};
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state) {
|
2011-07-10 20:18:06 +02:00
|
|
|
|
if (state->mapped)
|
|
|
|
|
xcb_change_window_attributes(conn, state->id, XCB_CW_EVENT_MASK, values);
|
2011-03-06 21:48:49 +01:00
|
|
|
|
}
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Done, EnterNotify disabled\n");
|
2010-07-11 23:41:02 +02:00
|
|
|
|
bool order_changed = false;
|
2011-08-04 22:19:30 +02:00
|
|
|
|
bool stacking_changed = false;
|
2011-08-03 20:07:03 +02:00
|
|
|
|
|
|
|
|
|
/* count first, necessary to (re)allocate memory for the bottom-to-top
|
|
|
|
|
* stack afterwards */
|
|
|
|
|
int cnt = 0;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state)
|
|
|
|
|
if (con_has_managed_window(state->con))
|
|
|
|
|
cnt++;
|
2011-08-03 20:07:03 +02:00
|
|
|
|
|
2014-04-08 20:27:40 +02:00
|
|
|
|
/* The bottom-to-top window stack of all windows which are managed by i3.
|
|
|
|
|
* Used for x_get_window_stack(). */
|
|
|
|
|
static xcb_window_t *client_list_windows = NULL;
|
|
|
|
|
static int client_list_count = 0;
|
|
|
|
|
|
|
|
|
|
if (cnt != client_list_count) {
|
|
|
|
|
client_list_windows = srealloc(client_list_windows, sizeof(xcb_window_t) * cnt);
|
|
|
|
|
client_list_count = cnt;
|
2011-08-03 20:07:03 +02:00
|
|
|
|
}
|
|
|
|
|
|
2014-04-08 20:27:40 +02:00
|
|
|
|
xcb_window_t *walk = client_list_windows;
|
2011-08-03 20:07:03 +02:00
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/* X11 correctly represents the stack if we push it from bottom to top */
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state) {
|
2014-05-02 22:54:34 +02:00
|
|
|
|
if (con_has_managed_window(state->con))
|
2011-08-03 20:07:03 +02:00
|
|
|
|
memcpy(walk++, &(state->con->window->id), sizeof(xcb_window_t));
|
|
|
|
|
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("stack: 0x%08x\n", state->id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
con_state *prev = CIRCLEQ_PREV(state, state);
|
|
|
|
|
con_state *old_prev = CIRCLEQ_PREV(state, old_state);
|
2011-08-04 22:19:30 +02:00
|
|
|
|
if (prev != old_prev)
|
2010-07-11 23:41:02 +02:00
|
|
|
|
order_changed = true;
|
2011-08-04 22:19:30 +02:00
|
|
|
|
if ((state->initial || order_changed) && prev != CIRCLEQ_END(&state_head)) {
|
|
|
|
|
stacking_changed = true;
|
2011-10-23 01:15:13 +02:00
|
|
|
|
//DLOG("Stacking 0x%08x above 0x%08x\n", prev->id, state->id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
uint32_t mask = 0;
|
|
|
|
|
mask |= XCB_CONFIG_WINDOW_SIBLING;
|
|
|
|
|
mask |= XCB_CONFIG_WINDOW_STACK_MODE;
|
|
|
|
|
uint32_t values[] = {state->id, XCB_STACK_MODE_ABOVE};
|
|
|
|
|
|
|
|
|
|
xcb_configure_window(conn, prev->id, mask, values);
|
|
|
|
|
}
|
2010-11-26 20:15:08 +01:00
|
|
|
|
state->initial = false;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
2011-08-03 20:07:03 +02:00
|
|
|
|
|
|
|
|
|
/* If we re-stacked something (or a new window appeared), we need to update
|
2014-04-08 20:27:40 +02:00
|
|
|
|
* the _NET_CLIENT_LIST and _NET_CLIENT_LIST_STACKING hints */
|
|
|
|
|
if (stacking_changed) {
|
|
|
|
|
DLOG("Client list changed (%i clients)\n", cnt);
|
|
|
|
|
ewmh_update_client_list_stacking(client_list_windows, client_list_count);
|
|
|
|
|
|
|
|
|
|
walk = client_list_windows;
|
|
|
|
|
|
|
|
|
|
/* reorder by initial mapping */
|
2014-06-19 11:20:32 +02:00
|
|
|
|
TAILQ_FOREACH(state, &initial_mapping_head, initial_mapping_order) {
|
2014-05-02 22:54:34 +02:00
|
|
|
|
if (con_has_managed_window(state->con))
|
2014-04-08 20:27:40 +02:00
|
|
|
|
*walk++ = state->con->window->id;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ewmh_update_client_list(client_list_windows, client_list_count);
|
|
|
|
|
}
|
2011-08-03 20:07:03 +02:00
|
|
|
|
|
2011-10-23 01:15:13 +02:00
|
|
|
|
DLOG("PUSHING CHANGES\n");
|
2011-08-26 19:11:46 +02:00
|
|
|
|
x_push_node(con);
|
|
|
|
|
|
2011-10-27 23:29:47 +02:00
|
|
|
|
if (warp_to) {
|
|
|
|
|
xcb_query_pointer_reply_t *pointerreply = xcb_query_pointer_reply(conn, pointercookie, NULL);
|
|
|
|
|
if (!pointerreply) {
|
|
|
|
|
ELOG("Could not query pointer position, not warping pointer\n");
|
|
|
|
|
} else {
|
|
|
|
|
int mid_x = warp_to->x + (warp_to->width / 2);
|
|
|
|
|
int mid_y = warp_to->y + (warp_to->height / 2);
|
|
|
|
|
|
|
|
|
|
Output *current = get_output_containing(pointerreply->root_x, pointerreply->root_y);
|
|
|
|
|
Output *target = get_output_containing(mid_x, mid_y);
|
2012-12-27 17:04:13 +01:00
|
|
|
|
if (current != target) {
|
|
|
|
|
/* Ignore MotionNotify events generated by warping */
|
2015-03-01 17:16:03 +01:00
|
|
|
|
xcb_change_window_attributes(conn, root, XCB_CW_EVENT_MASK, (uint32_t[]){XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT});
|
2011-10-27 23:29:47 +02:00
|
|
|
|
xcb_warp_pointer(conn, XCB_NONE, root, 0, 0, 0, 0, mid_x, mid_y);
|
2015-03-01 17:16:03 +01:00
|
|
|
|
xcb_change_window_attributes(conn, root, XCB_CW_EVENT_MASK, (uint32_t[]){ROOT_EVENT_MASK});
|
2012-12-27 17:04:13 +01:00
|
|
|
|
}
|
2016-01-09 13:13:57 +01:00
|
|
|
|
|
|
|
|
|
free(pointerreply);
|
2011-10-27 23:29:47 +02:00
|
|
|
|
}
|
|
|
|
|
warp_to = NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Re-enabling EnterNotify\n");
|
2011-07-10 20:18:06 +02:00
|
|
|
|
values[0] = FRAME_EVENT_MASK;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state) {
|
2011-07-10 20:18:06 +02:00
|
|
|
|
if (state->mapped)
|
|
|
|
|
xcb_change_window_attributes(conn, state->id, XCB_CW_EVENT_MASK, values);
|
2011-03-06 21:48:49 +01:00
|
|
|
|
}
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("Done, EnterNotify re-enabled\n");
|
2011-03-06 21:48:49 +01:00
|
|
|
|
|
2011-05-01 18:48:30 +02:00
|
|
|
|
x_deco_recurse(con);
|
2011-01-21 21:49:56 +01:00
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
xcb_window_t to_focus = focused->frame.id;
|
2010-03-27 15:25:51 +01:00
|
|
|
|
if (focused->window != NULL)
|
|
|
|
|
to_focus = focused->window->id;
|
|
|
|
|
|
|
|
|
|
if (focused_id != to_focus) {
|
2010-12-11 17:07:20 +01:00
|
|
|
|
if (!focused->mapped) {
|
|
|
|
|
DLOG("Not updating focus (to %p / %s), focused window is not mapped.\n", focused, focused->name);
|
2011-03-19 22:54:53 +01:00
|
|
|
|
/* Invalidate focused_id to correctly focus new windows with the same ID */
|
|
|
|
|
focused_id = XCB_NONE;
|
2010-12-11 17:07:20 +01:00
|
|
|
|
} else {
|
2011-03-18 17:07:56 +01:00
|
|
|
|
if (focused->window != NULL &&
|
2014-04-10 19:28:14 +02:00
|
|
|
|
focused->window->needs_take_focus &&
|
|
|
|
|
focused->window->doesnt_accept_focus) {
|
2012-01-18 20:16:57 +01:00
|
|
|
|
DLOG("Updating focus by sending WM_TAKE_FOCUS to window 0x%08x (focused: %p / %s)\n",
|
2012-01-18 00:33:33 +01:00
|
|
|
|
to_focus, focused, focused->name);
|
2014-03-29 05:25:52 +01:00
|
|
|
|
send_take_focus(to_focus, last_timestamp);
|
2014-02-22 11:52:01 +01:00
|
|
|
|
|
2014-05-31 18:06:39 +02:00
|
|
|
|
ewmh_update_active_window((con_has_managed_window(focused) ? focused->window->id : XCB_WINDOW_NONE));
|
|
|
|
|
|
2014-04-10 19:28:14 +02:00
|
|
|
|
if (to_focus != last_focused && is_con_attached(focused))
|
2014-06-15 19:07:02 +02:00
|
|
|
|
ipc_send_window_event("focus", focused);
|
2014-04-10 19:28:14 +02:00
|
|
|
|
} else {
|
2012-12-27 16:58:46 +01:00
|
|
|
|
DLOG("Updating focus (focused: %p / %s) to X11 window 0x%08x\n", focused, focused->name, to_focus);
|
2012-01-18 00:33:33 +01:00
|
|
|
|
/* We remove XCB_EVENT_MASK_FOCUS_CHANGE from the event mask to get
|
|
|
|
|
* no focus change events for our own focus changes. We only want
|
|
|
|
|
* these generated by the clients. */
|
|
|
|
|
if (focused->window != NULL) {
|
|
|
|
|
values[0] = CHILD_EVENT_MASK & ~(XCB_EVENT_MASK_FOCUS_CHANGE);
|
|
|
|
|
xcb_change_window_attributes(conn, focused->window->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
}
|
2016-05-05 20:46:33 +02:00
|
|
|
|
xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, to_focus, last_timestamp);
|
2012-01-18 00:33:33 +01:00
|
|
|
|
if (focused->window != NULL) {
|
|
|
|
|
values[0] = CHILD_EVENT_MASK;
|
|
|
|
|
xcb_change_window_attributes(conn, focused->window->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-31 18:06:39 +02:00
|
|
|
|
ewmh_update_active_window((con_has_managed_window(focused) ? focused->window->id : XCB_WINDOW_NONE));
|
2014-02-22 11:52:01 +01:00
|
|
|
|
|
|
|
|
|
if (to_focus != XCB_NONE && to_focus != last_focused && focused->window != NULL && is_con_attached(focused))
|
2014-06-15 19:07:02 +02:00
|
|
|
|
ipc_send_window_event("focus", focused);
|
2011-03-18 17:07:56 +01:00
|
|
|
|
}
|
2011-03-17 22:27:59 +01:00
|
|
|
|
|
2014-02-22 11:52:01 +01:00
|
|
|
|
focused_id = last_focused = to_focus;
|
2010-12-11 17:07:20 +01:00
|
|
|
|
}
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-19 20:43:06 +01:00
|
|
|
|
if (focused_id == XCB_NONE) {
|
2015-09-12 22:34:06 +02:00
|
|
|
|
/* If we still have no window to focus, we focus the EWMH window instead. We use this rather than the
|
|
|
|
|
* root window in order to avoid an X11 fallback mechanism causing a ghosting effect (see #1378). */
|
|
|
|
|
DLOG("Still no window focused, better set focus to the EWMH support window (%d)\n", ewmh_window);
|
2016-05-05 20:46:33 +02:00
|
|
|
|
xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, ewmh_window, last_timestamp);
|
2014-05-31 18:06:39 +02:00
|
|
|
|
ewmh_update_active_window(XCB_WINDOW_NONE);
|
2015-09-12 22:34:06 +02:00
|
|
|
|
focused_id = ewmh_window;
|
2011-03-19 20:43:06 +01:00
|
|
|
|
}
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
xcb_flush(conn);
|
2011-10-23 01:15:13 +02:00
|
|
|
|
DLOG("ENDING CHANGES\n");
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
2011-07-04 13:41:02 +02:00
|
|
|
|
/* Disable EnterWindow events for windows which will be unmapped in
|
|
|
|
|
* x_push_node_unmaps() now. Unmapping windows happens when switching
|
|
|
|
|
* workspaces. We want to avoid getting EnterNotifies during that phase
|
|
|
|
|
* because they would screw up our focus. One of these cases is having a
|
|
|
|
|
* stack with two windows. If the first window is focused and gets
|
|
|
|
|
* unmapped, the second one appears under the cursor and therefore gets an
|
|
|
|
|
* EnterNotify event. */
|
|
|
|
|
values[0] = FRAME_EVENT_MASK & ~XCB_EVENT_MASK_ENTER_WINDOW;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state) {
|
2011-07-04 13:41:02 +02:00
|
|
|
|
if (!state->unmap_now)
|
|
|
|
|
continue;
|
|
|
|
|
xcb_change_window_attributes(conn, state->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Push all pending unmaps */
|
2010-11-27 17:45:23 +01:00
|
|
|
|
x_push_node_unmaps(con);
|
|
|
|
|
|
2010-03-27 15:25:51 +01:00
|
|
|
|
/* save the current stack as old stack */
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH(state, &state_head, state) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
CIRCLEQ_REMOVE(&old_state_head, state, old_state);
|
|
|
|
|
CIRCLEQ_INSERT_TAIL(&old_state_head, state, old_state);
|
|
|
|
|
}
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//CIRCLEQ_FOREACH(state, &old_state_head, old_state) {
|
|
|
|
|
// DLOG("old stack: 0x%08x\n", state->id);
|
|
|
|
|
//}
|
2011-03-20 16:26:36 +01:00
|
|
|
|
|
|
|
|
|
xcb_flush(conn);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Raises the specified container in the internal stack of X windows. The
|
|
|
|
|
* next call to x_push_changes() will make the change visible in X11.
|
|
|
|
|
*
|
|
|
|
|
*/
|
2013-08-27 20:21:11 +02:00
|
|
|
|
void x_raise_con(Con *con) {
|
2010-03-27 15:25:51 +01:00
|
|
|
|
con_state *state;
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
state = state_for_frame(con->frame.id);
|
2011-05-14 20:04:34 +02:00
|
|
|
|
//DLOG("raising in new stack: %p / %s / %s / xid %08x\n", con, con->name, con->window ? con->window->name_json : "", state->id);
|
2010-03-27 15:25:51 +01:00
|
|
|
|
|
|
|
|
|
CIRCLEQ_REMOVE(&state_head, state, state);
|
|
|
|
|
CIRCLEQ_INSERT_HEAD(&state_head, state, state);
|
|
|
|
|
}
|
2010-11-14 16:41:46 +01:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Sets the WM_NAME property (so, no UTF8, but used only for debugging anyways)
|
|
|
|
|
* of the given name. Used for properly tagging the windows for easily spotting
|
|
|
|
|
* i3 windows in xwininfo -root -all.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void x_set_name(Con *con, const char *name) {
|
|
|
|
|
struct con_state *state;
|
|
|
|
|
|
Migrate i3 rendering to cairo.
This patch migrates all decoration rendering of i3 to cairo. Using the
compile switch CAIRO_SUPPORT, rendering can be switched back to the
previous XCB behavior, just like with the previous migration to cairo
in i3bar.
This patch also fixes a bug in draw_util.c where copying one surface
to another would use incorrect coordinates if the source coordinates
are not 0, 0.
Furthermore, this patch implicitly fixes some minor issues in the
decoration rendering which would be ignored previously due to the fact
that errors would only show up in the event queue, but not cause the
rendering code path to crash. One example is zero-height pixmaps which
are not allowed. Using cairo, these would cause i3 to instantly segfault,
so this patch avoids this.
Lastly, this patch annotates other issues found but not fixed in this patch
using TODO comments, e.g., the zero-height check not working correctly
and the comment that it should probably work the same way for zero-width
pixmaps.
relates to #1278
2015-11-16 21:26:06 +01:00
|
|
|
|
if ((state = state_for_frame(con->frame.id)) == NULL) {
|
2010-11-14 16:41:46 +01:00
|
|
|
|
ELOG("window state not found\n");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
FREE(state->name);
|
|
|
|
|
state->name = sstrdup(name);
|
|
|
|
|
}
|
2011-03-19 22:26:15 +01:00
|
|
|
|
|
2013-06-05 15:04:57 +02:00
|
|
|
|
/*
|
|
|
|
|
* Set up the I3_SHMLOG_PATH atom.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void update_shmlog_atom() {
|
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root,
|
2014-06-15 19:07:02 +02:00
|
|
|
|
A_I3_SHMLOG_PATH, A_UTF8_STRING, 8,
|
|
|
|
|
strlen(shmlogname), shmlogname);
|
2013-06-05 15:04:57 +02:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-19 22:26:15 +01:00
|
|
|
|
/*
|
|
|
|
|
* Sets up i3 specific atoms (I3_SOCKET_PATH and I3_CONFIG_PATH)
|
|
|
|
|
*
|
|
|
|
|
*/
|
2012-03-31 10:53:04 +02:00
|
|
|
|
void x_set_i3_atoms(void) {
|
2012-08-12 13:51:47 +02:00
|
|
|
|
pid_t pid = getpid();
|
2011-03-19 22:26:15 +01:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A_I3_SOCKET_PATH, A_UTF8_STRING, 8,
|
2011-03-20 15:34:34 +01:00
|
|
|
|
(current_socketpath == NULL ? 0 : strlen(current_socketpath)),
|
|
|
|
|
current_socketpath);
|
2012-08-12 13:51:47 +02:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A_I3_PID, XCB_ATOM_CARDINAL, 32, 1, &pid);
|
2011-03-19 22:26:15 +01:00
|
|
|
|
xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A_I3_CONFIG_PATH, A_UTF8_STRING, 8,
|
|
|
|
|
strlen(current_configpath), current_configpath);
|
2013-06-05 15:04:57 +02:00
|
|
|
|
update_shmlog_atom();
|
2011-03-19 22:26:15 +01:00
|
|
|
|
}
|
2011-08-12 03:54:59 +02:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Set warp_to coordinates. This will trigger on the next call to
|
|
|
|
|
* x_push_changes().
|
|
|
|
|
*
|
|
|
|
|
*/
|
2014-06-15 19:07:02 +02:00
|
|
|
|
void x_set_warp_to(Rect *rect) {
|
2014-06-28 13:04:52 +02:00
|
|
|
|
if (config.mouse_warping != POINTER_WARPING_NONE)
|
2014-01-04 13:04:56 +01:00
|
|
|
|
warp_to = rect;
|
2011-08-12 03:54:59 +02:00
|
|
|
|
}
|
2011-12-17 19:47:29 +01:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Applies the given mask to the event mask of every i3 window decoration X11
|
|
|
|
|
* window. This is useful to disable EnterNotify while resizing so that focus
|
|
|
|
|
* is untouched.
|
|
|
|
|
*
|
|
|
|
|
*/
|
|
|
|
|
void x_mask_event_mask(uint32_t mask) {
|
2014-06-15 19:07:02 +02:00
|
|
|
|
uint32_t values[] = {FRAME_EVENT_MASK & mask};
|
2011-12-17 19:47:29 +01:00
|
|
|
|
|
|
|
|
|
con_state *state;
|
2014-06-19 11:20:32 +02:00
|
|
|
|
CIRCLEQ_FOREACH_REVERSE(state, &state_head, state) {
|
2011-12-17 19:47:29 +01:00
|
|
|
|
if (state->mapped)
|
|
|
|
|
xcb_change_window_attributes(conn, state->id, XCB_CW_EVENT_MASK, values);
|
|
|
|
|
}
|
|
|
|
|
}
|